Merge lp://qastaging/~mpontillo/maas/remove-iscpy-trunk into lp://qastaging/~maas-committers/maas/trunk
Proposed by
Mike Pontillo
Status: | Merged |
---|---|
Approved by: | Mike Pontillo |
Approved revision: | no longer in the source branch. |
Merged at revision: | 4068 |
Proposed branch: | lp://qastaging/~mpontillo/maas/remove-iscpy-trunk |
Merge into: | lp://qastaging/~maas-committers/maas/trunk |
Diff against target: |
546 lines (+470/-10) 5 files modified
buildout.cfg (+0/-1) src/maasserver/management/commands/edit_named_options.py (+8/-8) src/maasserver/utils/isc.py (+283/-0) src/maasserver/utils/tests/test_isc.py (+179/-0) versions.cfg (+0/-1) |
To merge this branch: | bzr merge lp://qastaging/~mpontillo/maas/remove-iscpy-trunk |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Review via email:
|
Commit message
Remove dependency on iscpy. Add MAAS utility (based on iscpy) for parsing named.options. Add tests for iscpy-derived code.
Description of the change
To post a comment you must log in.
Looks good.
The code that has come from iscpy is fairly gnarly and inefficient. I'll bet we can improve on that a lot.