Merge lp://qastaging/~mpt/apport/bug-961065 into lp://qastaging/~apport-hackers/apport/trunk

Proposed by Matthew Paul Thomas
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp://qastaging/~mpt/apport/bug-961065
Merge into: lp://qastaging/~apport-hackers/apport/trunk
Diff against target: 1095 lines (+86/-86)
84 files modified
gtk/apport-gtk.ui (+1/-1)
kde/bugreport.ui (+1/-1)
po/ace.po (+1/-1)
po/af.po (+1/-1)
po/am.po (+1/-1)
po/an.po (+1/-1)
po/apport.pot (+1/-1)
po/ar.po (+1/-1)
po/ast.po (+1/-1)
po/be.po (+1/-1)
po/bg.po (+1/-1)
po/bn.po (+1/-1)
po/br.po (+1/-1)
po/bs.po (+1/-1)
po/ca.po (+1/-1)
po/ca@valencia.po (+1/-1)
po/cs.po (+1/-1)
po/cv.po (+1/-1)
po/da.po (+1/-1)
po/de.po (+1/-1)
po/el.po (+1/-1)
po/en_AU.po (+2/-2)
po/en_CA.po (+1/-1)
po/en_GB.po (+2/-2)
po/eo.po (+1/-1)
po/es.po (+1/-1)
po/et.po (+1/-1)
po/eu.po (+1/-1)
po/fa.po (+1/-1)
po/fi.po (+1/-1)
po/fr.po (+1/-1)
po/ga.po (+1/-1)
po/gd.po (+1/-1)
po/gl.po (+1/-1)
po/gu.po (+1/-1)
po/he.po (+1/-1)
po/hi.po (+1/-1)
po/hr.po (+1/-1)
po/hu.po (+1/-1)
po/hy.po (+1/-1)
po/id.po (+1/-1)
po/is.po (+1/-1)
po/it.po (+1/-1)
po/ja.po (+1/-1)
po/kab.po (+1/-1)
po/kk.po (+1/-1)
po/km.po (+1/-1)
po/kn.po (+1/-1)
po/ko.po (+1/-1)
po/ku.po (+1/-1)
po/lo.po (+1/-1)
po/lt.po (+1/-1)
po/lv.po (+1/-1)
po/mk.po (+1/-1)
po/ml.po (+1/-1)
po/ms.po (+1/-1)
po/nb.po (+1/-1)
po/nds.po (+1/-1)
po/ne.po (+1/-1)
po/nl.po (+1/-1)
po/oc.po (+1/-1)
po/pl.po (+1/-1)
po/pt.po (+1/-1)
po/pt_BR.po (+1/-1)
po/ro.po (+1/-1)
po/ru.po (+1/-1)
po/sc.po (+1/-1)
po/shn.po (+1/-1)
po/si.po (+1/-1)
po/sk.po (+1/-1)
po/sl.po (+1/-1)
po/sq.po (+1/-1)
po/sr.po (+1/-1)
po/sv.po (+1/-1)
po/ta.po (+1/-1)
po/te.po (+1/-1)
po/th.po (+1/-1)
po/tr.po (+1/-1)
po/ug.po (+1/-1)
po/uk.po (+1/-1)
po/vi.po (+1/-1)
po/zh_CN.po (+1/-1)
po/zh_HK.po (+1/-1)
po/zh_TW.po (+1/-1)
To merge this branch: bzr merge lp://qastaging/~mpt/apport/bug-961065
Reviewer Review Type Date Requested Status
Martin Pitt (community) Disapprove
Review via email: mp+98607@code.qastaging.launchpad.net

Description of the change

Fixes bug 961065 (Alert inappropriately refers to 'program version' for internal errors).

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

I'd like to keep the current string if the dialog actually mentions a program name, also to mitigate the string freeze impact.

We cannot just change all msgids in .po files, as translations will still refer to "program version". We actually need new translations for this.

So I'll come up with a more dynamic solution to this. I'll follow up in the bug report.

Thanks!

review: Disapprove

Unmerged revisions

2236. By Matthew Paul Thomas

Fixes bug 961065 (Alert inappropriately refers to 'program version' for internal errors).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches