Merge ~mreed8855/plainbox-provider-checkbox:remove_qemu into plainbox-provider-checkbox:master

Proposed by Michael Reed
Status: Needs review
Proposed branch: ~mreed8855/plainbox-provider-checkbox:remove_qemu
Merge into: plainbox-provider-checkbox:master
Diff against target: 544 lines (+0/-506)
1 file modified
bin/virtualization.py (+0/-506)
Reviewer Review Type Date Requested Status
Jeff Lane  Needs Fixing
Devices Certification Bot Needs Fixing
Review via email: mp+430834@code.qastaging.launchpad.net

Commit message

The old qemu code was not being used so I removed it. It has been replaced with the lxd vm test.

Description of the change

he old qemu code was not being used so I removed it. It has been replaced with the lxd vm test.

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Great! Thanks for the cleanup.

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

"10.38.105.54"
"10.38.105.165"
"10.38.105.108"
"10.38.105.197"
[xenial] [14:51:36] starting container
[focal] [14:51:37] starting container
[bionic] [14:51:39] starting container
[jammy] [14:51:40] starting container
Device project added to xenial-testing
Device project added to focal-testing
Device project added to jammy-testing
Device project added to bionic-testing
"10.38.105.54"
[xenial] [14:52:01] provisioning container
"10.38.105.40"
[focal] [14:52:03] provisioning container
"10.38.105.136"
[jammy] [14:52:12] provisioning container
"10.38.105.157"
[bionic] [14:52:12] provisioning container
[xenial] [14:53:44] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[bionic] [14:54:07] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-checkbox
[jammy] [14:55:27] Starting tests...
[jammy] Found a test script: ./requirements/container-tests-provider-checkbox
[bionic] [14:55:51] container-tests-provider-checkbox: FAIL
[xenial] [14:55:54] container-tests-provider-checkbox: FAIL
[bionic] output: https://paste.ubuntu.com/p/9k4gn376mv/
[bionic] [14:55:55] Fixing file permissions in source directory
[bionic] [14:55:55] Destroying container
[xenial] output: https://paste.ubuntu.com/p/rpSbTXWZZD/
[xenial] [14:55:58] Fixing file permissions in source directory
[xenial] [14:55:58] Destroying container
[jammy] [14:57:23] container-tests-provider-checkbox: FAIL
[jammy] output: https://paste.ubuntu.com/p/khXqM38wJx/
[jammy] [14:57:26] Fixing file permissions in source directory
[jammy] [14:57:26] Destroying container
[focal] [14:58:18] Starting tests...
[focal] Found a test script: ./requirements/container-tests-provider-checkbox
[focal] [15:00:31] container-tests-provider-checkbox: FAIL
[focal] output: https://paste.ubuntu.com/p/TK3vcVYj8G/
[focal] [15:00:33] Fixing file permissions in source directory
[focal] [15:00:33] Destroying container

review: Needs Fixing
Revision history for this message
Jeff Lane  (bladernr) wrote :

test_flake8_/root/project/bin/virtualization.py (plainbox.provider_manager.Flake8Tests) ... /root/project/bin/virtualization.py:29:1: F401 'requests' imported but unused
/root/project/bin/virtualization.py:31:1: F401 'subprocess.check_output' imported but unused
/root/project/bin/virtualization.py:31:1: F401 'subprocess.call' imported but unused
/root/project/bin/virtualization.py:40:1: F401 'tempfile' imported but unused
/root/project/bin/virtualization.py:41:1: F401 'tarfile' imported but unused

Looks like maybe there are still things that need to be removed...

review: Needs Fixing

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches