Merge lp://qastaging/~mriya3/simple-scan/copy-to-clipboard-branch into lp://qastaging/~simple-scan-team/simple-scan/trunk
Proposed by
Amos Brocco
| Status: | Merged |
|---|---|
| Merged at revision: | 613 |
| Proposed branch: | lp://qastaging/~mriya3/simple-scan/copy-to-clipboard-branch |
| Merge into: | lp://qastaging/~simple-scan-team/simple-scan/trunk |
| Diff against target: |
123 lines (+53/-1) 3 files modified
data/simple-scan.ui (+27/-0) src/page.vala (+8/-0) src/ui.vala (+18/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mriya3/simple-scan/copy-to-clipboard-branch |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Ancell | Approve | ||
|
Review via email:
|
|||
Description of the change
The included patch implements "copy to clipboard", to directly copy a scanned page (or a portion of it) to the clipboard.
To post a comment you must log in.
Revision history for this message
| Robert Ancell (robert-ancell) wrote | # |
Revision history for this message
| Robert Ancell (robert-ancell) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for that! I pushed with some changes:
- Removed the copy button from the toolbar - it doesn't need to be that prominent
- Moved the menu item to the 'Page' menu - copy relates to pages not document. This also means it shows up in the right click menu.
- Fixed some more tab characters and use of braces