AppMenu GTK+

Merge lp://qastaging/~mterry/appmenu-gtk/fix-timeout-crash into lp://qastaging/appmenu-gtk/0.4

  1. fix-timeout-crash
  2. Merge into trunk
Proposed by Michael Terry
Status: Merged
Merged at revision: 124
Proposed branch: lp://qastaging/~mterry/appmenu-gtk/fix-timeout-crash
Merge into: lp://qastaging/appmenu-gtk/0.4
Diff against target: 29 lines (+7/-1)
1 file modified
src/bridge.c (+7/-1)
To merge this branch: bzr merge lp://qastaging/~mterry/appmenu-gtk/fix-timeout-crash
Reviewer Review Type Date Requested Status
Cody Russell (community) Approve
Review via email: mp+52239@code.qastaging.launchpad.net

Description of the change

This fixes a crash under valgrind apparently due to a toplevel dying before we can get to it. I couldn't reproduce, but seb128 could and he confirmed this fixes it.

To post a comment you must log in.
Revision history for this message
Cody Russell (bratsche) :
review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

Wait a sec on this. Seb sees a new crash with it.

lp://qastaging/~mterry/appmenu-gtk/fix-timeout-crash updated
125. By Michael Terry

make sure we always remove weak pointer if necessary

Revision history for this message
Michael Terry (mterry) wrote :

OK, fixed now

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches