Merge lp://qastaging/~mterry/appmenu-gtk/rebuild-if-realized into lp://qastaging/appmenu-gtk/0.4

Proposed by Michael Terry
Status: Merged
Merged at revision: 114
Proposed branch: lp://qastaging/~mterry/appmenu-gtk/rebuild-if-realized
Merge into: lp://qastaging/appmenu-gtk/0.4
Diff against target: 22 lines (+10/-3)
1 file modified
src/bridge.c (+10/-3)
To merge this branch: bzr merge lp://qastaging/~mterry/appmenu-gtk/rebuild-if-realized
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+48827@code.qastaging.launchpad.net

Description of the change

This fixes issues with Java SWT apps that I hit when debugging eclipse's menus. This doesn't fix eclipse, but does fix simple SWT-using apps.

The problem was that the insert() function was ignoring already-realized toplevels and assuming that they would be realized only in the future. This patch fixes that. See bug 618587 for context and a sample app.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

  review approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches