Merge lp://qastaging/~mterry/indicator-network/snap-root into lp://qastaging/indicator-network
Proposed by
Michael Terry
| Status: | Merged |
|---|---|
| Approved by: | Antti Kaijanmäki |
| Approved revision: | 634 |
| Merged at revision: | 649 |
| Proposed branch: | lp://qastaging/~mterry/indicator-network/snap-root |
| Merge into: | lp://qastaging/indicator-network |
| Diff against target: |
19 lines (+2/-2) 2 files modified
data/indicator-network-secret-agent.conf.in (+1/-1) data/indicator-network.conf.in (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mterry/indicator-network/snap-root |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Antti Kaijanmäki (community) | Approve | ||
| unity-api-1-bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Work inside a snap by prefixing hard coded paths with $SNAP.
Description of the change
There are also two hardcoded paths in the data/*.desktop.in files. But that's a static desktop file, so $SNAP isn't appropriate.
I'm not sure what the best solution for those is, but presumably it would lie in whichever component consumes the desktop file, not this package.
To post a comment you must log in.
Revision history for this message
| unity-api-1-bot (unity-api-1-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:634
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/