Merge lp://qastaging/~mterry/indicator-printers/snap-root into lp://qastaging/indicator-printers
Proposed by
Michael Terry
| Status: | Merged |
|---|---|
| Approved by: | dobey |
| Approved revision: | 75 |
| Merged at revision: | 79 |
| Proposed branch: | lp://qastaging/~mterry/indicator-printers/snap-root |
| Merge into: | lp://qastaging/indicator-printers |
| Diff against target: |
9 lines (+1/-1) 1 file modified
data/indicator-printers.conf.in (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mterry/indicator-printers/snap-root |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| unity-api-1-bot | continuous-integration | Approve | |
| Indicator Applet Developers | Pending | ||
|
Review via email:
|
|||
Commit message
Work inside a snap by prefixing hard coded paths with $SNAP.
Description of the change
There are also two hardcoded paths in the data/*.desktop.in files. But that's a static desktop file, so $SNAP isn't appropriate.
I'm not sure what the best solution for those is, but presumably it would lie in whichever component consumes the desktop file, not this package.
To post a comment you must log in.
Revision history for this message
| unity-api-1-bot (unity-api-1-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| unity-api-1-bot (unity-api-1-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:75
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/