Merge lp://qastaging/~mterry/libunity-misc/modernize-build into lp://qastaging/libunity-misc

Proposed by Michael Terry
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 41
Merged at revision: 35
Proposed branch: lp://qastaging/~mterry/libunity-misc/modernize-build
Merge into: lp://qastaging/libunity-misc
Diff against target: 349 lines (+145/-104)
11 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/changelog (+9/-0)
debian/compat (+1/-1)
debian/control (+12/-9)
debian/copyright (+100/-75)
debian/libunity-misc-dev.install (+3/-3)
debian/libunity-misc-doc.install (+1/-1)
debian/libunity-misc4.install (+1/-1)
debian/rules (+14/-13)
debian/source/format (+1/-0)
unity-misc.pc.in (+1/-1)
To merge this branch: bzr merge lp://qastaging/~mterry/libunity-misc/modernize-build
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+139499@code.qastaging.launchpad.net

Commit message

Modernize build system by porting to dh9 and cleaning up packaging

Description of the change

Modernize build system by porting to dh9. Plus some other cleanups around the place. Including adding gtk+-3.0 to the pc file.

To post a comment you must log in.
39. By Michael Terry

fix copyright fields

40. By Michael Terry

add multiarch Pre-Depends and use gensymbols level 4

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hum, this looks mostly good but:
- you didn't bump the version, so bzr bd try to use the old tarball and can't rerun everything. Maybe you should bump to 4.0.5
- thre is no split mode and .bzr-buildddeb/ dir (forgotten bzr add? ;))

review: Needs Fixing
41. By Michael Terry

bump version and add bzr-builddeb split mode config

Revision history for this message
Michael Terry (mterry) wrote :

Good catches! Added the bzr-builddeb and bumped the version. Please re-review!

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looking very good to me :) Approving.
Thanks Michael! One less on the list.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: