Merge lp://qastaging/~mterry/lightdm/shut-down-dbus into lp://qastaging/lightdm
Proposed by
Michael Terry
Status: | Rejected |
---|---|
Rejected by: | Robert Ancell |
Proposed branch: | lp://qastaging/~mterry/lightdm/shut-down-dbus |
Merge into: | lp://qastaging/lightdm |
Diff against target: |
80 lines (+44/-0) 4 files modified
src/Makefile.am (+1/-0) src/display.c (+6/-0) utils/Makefile.am (+1/-0) utils/lightdm-greeter-session (+36/-0) |
To merge this branch: | bzr merge lp://qastaging/~mterry/lightdm/shut-down-dbus |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Needs Fixing | ||
Review via email:
|
Description of the change
Greeters like to autostart dbus by making dbus calls. This normally works fine, because such autostarted sessions are closed when X is. But since lightdm re-uses X, the dbus-daemon and its spawn were surviving login.
This branch adds a wrapper for greeter sessions that ensures everything is cleaned up correctly.
To post a comment you must log in.
Unmerged revisions
- 1069. By Michael Terry
-
use wrapper for greeter to ensure that dbus dies when the greeter does
Ech. LightDM really doesn't know (or care) what the greeter is so doing this is making big assumptions about the greeter behaviour. All processes spawned by the greeter should be killed, but this is probably better solved using cgroups.
We should move this into the gtk-greeter / Unity greeter, as hacks are OK there, but I'd like to keep this sort of thing out of lightdm core.