Merge lp://qastaging/~mterry/notify-osd/no-border into lp://qastaging/~canonical-dx-team/notify-osd/precise
Status: | Merged |
---|---|
Approved by: | Allan LeSage |
Approved revision: | 457 |
Merged at revision: | 457 |
Proposed branch: | lp://qastaging/~mterry/notify-osd/no-border |
Merge into: | lp://qastaging/~canonical-dx-team/notify-osd/precise |
Diff against target: |
770 lines (+212/-178) 5 files modified
src/bubble.c (+162/-138) src/defaults.c (+23/-22) src/defaults.h (+4/-3) src/display.c (+13/-10) src/stack.c (+10/-5) |
To merge this branch: | bzr merge lp://qastaging/~mterry/notify-osd/no-border |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Didier Roche-Tolomelli | Approve | ||
jenkins (community) | continuous-integration | Approve | |
Mirco Müller | Pending | ||
Review via email: mp+121956@code.qastaging.launchpad.net |
Description of the change
When running without a compositor, there is an ugly black border.
This branch fixes that by:
1) Adding an 'is_composited' argument to defaults_
2) Adding a 'GdkScreen **screen' argument to defaults_
3) Using these throughout to check composited state wherever these are used.
Additionally, I had to add some oddness in bubble.c for _refresh_
PASSED: Continuous integration, rev:457 s-jenkins: 8080/job/ notify- osd-ci/ 3/ s-jenkins: 8080/job/ notify- osd-ci/ ./label= precise- clean-amd64/ 3/console s-jenkins: 8080/job/ notify- osd-ci/ ./label= precise- clean-i386/ 3/console
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://