podbird

Merge lp://qastaging/~mterry/podbird/theme-colors into lp://qastaging/podbird/devel

  1. theme-colors
  2. Merge into devel
Proposed by Michael Terry
Status: Needs review
Proposed branch: lp://qastaging/~mterry/podbird/theme-colors
Merge into: lp://qastaging/podbird/devel
Prerequisite: lp://qastaging/~mterry/podbird/ok
Diff against target: 1190 lines (+91/-228)
27 files modified
app/components/ActionButton.qml (+2/-2)
app/components/Card.qml (+3/-3)
app/components/CustomProgressBar.qml (+2/-2)
app/components/CustomSectionHeader.qml (+2/-2)
app/components/EmptyState.qml (+3/-3)
app/components/HeaderListItem.qml (+0/-1)
app/components/SingleValueListItem.qml (+1/-2)
app/components/Walkthrough.qml (+4/-4)
app/podbird.qml (+2/-8)
app/settings/About.qml (+0/-7)
app/settings/CleanSetting.qml (+1/-5)
app/settings/Credits.qml (+0/-1)
app/settings/DownloadSetting.qml (+1/-5)
app/settings/ThemeSetting.qml (+1/-5)
app/themes/Dark.qml (+7/-23)
app/themes/Light.qml (+7/-23)
app/ui/EpisodesPage.qml (+13/-28)
app/ui/EpisodesTab.qml (+6/-24)
app/ui/FullPlayingView.qml (+11/-12)
app/ui/NowPlayingPage.qml (+0/-7)
app/ui/PlayerControls.qml (+14/-7)
app/ui/PodcastsTab.qml (+1/-11)
app/ui/Queue.qml (+2/-3)
app/ui/SearchPage.qml (+3/-17)
app/ui/SettingsPage.qml (+3/-21)
app/welcomewizard/Slide1.qml (+1/-1)
app/welcomewizard/Slide7.qml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~mterry/podbird/theme-colors
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan Needs Information
Review via email: mp+296062@code.qastaging.launchpad.net

Commit message

Update colors to match current Ubuntu theme colors.

Description of the change

Use system theme light/dark colors instead of custom ones.

This also reduces the use of green to just positive button actions. Blue is used instead for progress and selected states, like other apps.

To post a comment you must log in.
lp://qastaging/~mterry/podbird/theme-colors updated
150. By Michael Terry

Whoops, remove testing string

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Hmm I am having doubts about this. The green color we use is part of the app branding. Reverting this to the system colors defies this purpose. I'll defer this decision to Michael Sheldon.

review: Needs Information
Reply
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

@Michael Terry, BTW Thanks a lot for these patches!

Reply
Revision history for this message
Michael Terry (mterry) wrote :

No worries if you don't like it. I get it if you prefer branded colors.

Reply

Unmerged revisions

150. By Michael Terry

Whoops, remove testing string

149. By Michael Terry

Use theme colors more consistently

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches