Merge lp://qastaging/~mterry/qtubuntu/qmldir into lp://qastaging/qtubuntu

Proposed by Michael Terry
Status: Rejected
Rejected by: Gerry Boland
Proposed branch: lp://qastaging/~mterry/qtubuntu/qmldir
Merge into: lp://qastaging/qtubuntu
Diff against target: 10 lines (+1/-1)
1 file modified
src/modules/application/application.pro (+1/-1)
To merge this branch: bzr merge lp://qastaging/~mterry/qtubuntu/qmldir
Reviewer Review Type Date Requested Status
Michał Sawicz Needs Information
PS Jenkins bot continuous-integration Approve
Review via email: mp+160977@code.qastaging.launchpad.net

Commit message

Install into qt5/qml rather than qt5/imports.

Description of the change

qtubuntu currently installs into qt5/imports rather than qt5/qml like most of the other qml plugins. Is there a reason for this? A simple "import Ubuntu.Application 0.1" can't find the plugin in qt5/imports.

So I've changed it in this branch, but I very well may not understand the directory structure.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

I just ran into this problem following the instructions on here: https://wiki.ubuntu.com/Touch/Testing/Mir

Does anyone know why this is in imports rather than qml?

Revision history for this message
Michał Sawicz (saviq) wrote :

It's debatable whether this should be installed into QT_INSTALL_QML, too, as Ubuntu.Application is not meant to be imported by applications, but only the shell.

Unity8's private plugins live in $LIBDIR/unity8/qml - and that could be one place where shell-facing plugins should get instaslled - or even better - there should be a separate, generic (not unity8-specific, like ubuntu/qml/shell or something) location, where shell-only plugins would get installed.

review: Needs Information
Revision history for this message
Gerry Boland (gerboland) wrote :

Surface Flinger support dropped, this change out of date. Rejecting

Unmerged revisions

128. By Michael Terry

Install into qml dir rather than imports dir

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches