Snapcraft

Merge lp://qastaging/~mterry/snapcraft/debian-packaging into lp://qastaging/~snappy-dev/snapcraft/core

  1. debian-packaging
  2. Merge into core
Proposed by Michael Terry
Status: Merged
Merged at revision: 70
Proposed branch: lp://qastaging/~mterry/snapcraft/debian-packaging
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 215 lines (+131/-4)
12 files modified
.bzrignore (+3/-0)
bin/snapcraft (+12/-1)
debian/changelog (+5/-0)
debian/compat (+1/-0)
debian/control (+25/-0)
debian/copyright (+22/-0)
debian/rules (+11/-0)
debian/source/format (+1/-0)
debian/source/options (+7/-0)
setup.py (+41/-0)
snapcraft/common.py (+2/-0)
snapcraft/plugin.py (+1/-3)
To merge this branch: bzr merge lp://qastaging/~mterry/snapcraft/debian-packaging
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Ricardo Salveti (community) Needs Fixing
Review via email: mp+263937@code.qastaging.launchpad.net

Commit message

Add debian packaging.

Description of the change

Add debian packaging.

I've also added a setup.py to make building snapcraft follow python conventions. And I've made bin/snapcraft look at whether it's running from trunk or an installed system and look for its data files appropriately.

To post a comment you must log in.
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Got the following when building with sbuild:

py3versions: no X-Python3-Version in control file, using supported versions
dh clean --with python3
   dh_testdir
   dh_auto_clean
Can't exec "pyversions": No such file or directory at /usr/share/perl5/Debian/Debhelper/Buildsystem/python_distutils.pm line 120.

From my system that is provided by python3-minimal, wonder if we need to manually depend on that instead.

review: Needs Fixing
Revision history for this message
Michael Terry (mterry) wrote :

Ah yes, I forgot the critical step of building in a chroot. /.\

Fixed now.

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, this looks good, great to see that the packaging is there now! I have one minor idea/suggestion inline but not important at all, this can land as is.

review: Approve
Revision history for this message
Michael Terry (mterry) :
Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

The attempt to merge lp:~mterry/snapcraft/debian-packaging into lp:snapcraft failed. Below is the output from the failed tests.

/bin/sh: 1: ./.tarmac.sh: not found

Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

The attempt to merge lp:~mterry/snapcraft/debian-packaging into lp:snapcraft failed. Below is the output from the failed tests.

++ pwd
+ export PATH=/tmp/tarmac/branch.FpXQ_I/bin:/usr/bin:/bin
+ PATH=/tmp/tarmac/branch.FpXQ_I/bin:/usr/bin:/bin
++ pwd
+ export PYTHONPATH=/tmp/tarmac/branch.FpXQ_I:
+ PYTHONPATH=/tmp/tarmac/branch.FpXQ_I:
+ SRC_PATHS='bin snapcraft tests/unit'
+ pep8 bin snapcraft tests/unit --ignore=E501
./runtests.sh: line 26: pep8: command not found

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches