Merge lp://qastaging/~mterry/snapcraft/go-on-arm into lp://qastaging/~snappy-dev/snapcraft/core
| Status: | Merged |
|---|---|
| Approved by: | Sergio Schvezov |
| Approved revision: | 122 |
| Merged at revision: | 132 |
| Proposed branch: | lp://qastaging/~mterry/snapcraft/go-on-arm |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
139 lines (+40/-31) 7 files modified
examples/godd/snapcraft.yaml (+1/-1) examples/gopaste/snapcraft.yaml (+1/-1) examples/webcam-webui-snap/snapcraft.yaml (+1/-1) plugins/go-project.yaml (+2/-2) plugins/go.yaml (+0/-1) snapcraft/plugins/go.py (+34/-24) snapcraft/plugins/go_project.py (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mterry/snapcraft/go-on-arm |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sergio Schvezov | Approve | ||
|
Review via email:
|
|||
Commit message
Support the Go compiler on all arches, not just amd64.
This switches from using Google's pre-built binaries to using our archive builds of Google's compiler, thus giving us all platforms we support. And matching what we do for Python and Java.
Since this means we use whichever version of Go the host platform has, I've dropped the "1.4" from the plugin names.
I've tested this on wily and trusty.
Description of the change
Support the Go compiler on all arches, not just amd64.
This switches from using Google's pre-built binaries to using our archive builds of Google's compiler, thus giving us all platforms we support. And matching what we do for Python and Java.
Since this means we use whichever version of Go the host platform has, I've dropped the "1.4" from the plugin names.
I've tested this on wily and trusty.
| Michael Terry (mterry) wrote | # |
Looks good, one minor comment to catch up with trunk