Merge lp://qastaging/~mterry/snapcraft/local-plugins into lp://qastaging/~snappy-dev/snapcraft/core

Proposed by Michael Terry
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 78
Merged at revision: 75
Proposed branch: lp://qastaging/~mterry/snapcraft/local-plugins
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Prerequisite: lp://qastaging/~mterry/snapcraft/lifecycle-fixes2
Diff against target: 161 lines (+73/-9)
7 files modified
.bzrignore (+6/-3)
snapcraft/plugin.py (+25/-5)
snapcraft/yaml.py (+8/-1)
tests/plainbox/data/local-plugin/parts/plugins/local-plugin.yaml (+1/-0)
tests/plainbox/data/local-plugin/parts/plugins/local_plugin.py (+22/-0)
tests/plainbox/data/local-plugin/snapcraft.yaml (+2/-0)
tests/plainbox/units/jobs.pxu (+9/-0)
To merge this branch: bzr merge lp://qastaging/~mterry/snapcraft/local-plugins
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
Review via email: mp+264305@code.qastaging.launchpad.net

Commit message

Add support for local plugins in parts/plugins.

Description of the change

Add support for local plugins in parts/plugins.

We discussed being able to specify a separate local plugin path in the Isle of Man, but that isn't implemented yet.

To post a comment you must log in.
77. By Michael Terry

Drop errant ls

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Looks good, one minor question inline, feel free to merge it.

review: Approve
78. By Michael Terry

Add notice when using a local plugin

Revision history for this message
Michael Terry (mterry) wrote :

OK, I added an extra log notice.

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches