Merge lp://qastaging/~mterry/snapcraft/yaml-info into lp://qastaging/~snappy-dev/snapcraft/abandoned-go-trunk

Nice work! I added some inline comments but its mostly nitpicking, feel free to ignore.

OK, added comments to your nits, and switched from a custom test setup func to SetUpTest. Thanks!

Nice update! Interessting that ErrorMatch/Matches does not work on multiline strings. Haven't used it for that yet myself.

Hope its ok that I top-approved this - or is that something you want to handle inside your sub-project yourself, i.e. only one of the two of you should top-approve? I don't mind I just don't want to stop on toes here :)

The attempt to merge lp:~mterry/snapcraft/yaml-info into lp:snapcraft failed. Below is the output from the failed tests.

/bin/sh: 1: ./.tarmac.sh: Permission denied

Good question. I'm not sure? Maybe this early on, it would be good to have Ted look at it too. But in general, I'd like to be in the whole snappy umbrella review team. That way we get awesome Go advice from you folks (i.e. you stop us from doing stupid Go things) and keep conventions the same. :)

OK, Ted said he looked it over and said it's fine. Thanks for the review, mvo!

The attempt to merge lp:~mterry/snapcraft/yaml-info into lp:snapcraft failed. Below is the output from the failed tests.

Checking docs
Checking formatting
Installing godeps
Install golint
Obtaining dependencies
update github.com/jessevdk/go-flags failed; trying to fetch newer version
update gopkg.in/check.v1 failed; trying to fetch newer version
github.com/jessevdk/go-flags now at 15347ef417a300349807983f15af9e65cd2e1b3a
gopkg.in/check.v1 now at 64131543e7896d5bcc6bd5a76287eb75ea96c673
Building

# we always run in a fresh dir in tarmac
export GOPATH=$(mktemp -d)
trap 'rm -rf "$GOPATH"' EXIT

# this is a hack, but not sure tarmac is golang friendly
mkdir -p $GOPATH/src/launchpad.net/snapcraft
cp -a . $GOPATH/src/launchpad.net/snapcraft/
cd $GOPATH/src/launchpad.net/snapcraft

./run-checks

if which goctest >/dev/null; then
    goctest="goctest"
else
    goctest="go test"
fi

echo Checking docs
./mdlint.py README.md docs/*.md

echo Checking formatting
fmt=$(gofmt -l .)

if [ -n "$fmt" ]; then
    echo "Formatting wrong in following files"
    echo $fmt
    exit 1
fi

echo Installing godeps
go get launchpad.net/godeps
export PATH=$PATH:$GOPATH/bin

echo Install golint
go get github.com/golang/lint/golint
export PATH=$PATH:$GOPATH/bin

echo Obtaining dependencies
godeps -u dependencies.tsv

echo Building
go build -v launchpad.net/snapcraft/...
config/yaml.go:26:2: cannot find package "gopkg.in/yaml.v2" in any of:
 /usr/lib/go/src/pkg/gopkg.in/yaml.v2 (from $GOROOT)
 /home/tarmac/tmp/tmp.5bGMFmzBB5/src/gopkg.in/yaml.v2 (from $GOPATH)