Merge lp://qastaging/~mterry/ubuntu-system-settings/wizard-introspection-rtm into lp://qastaging/ubuntu-system-settings/rtm-14.09

Proposed by Michael Terry
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://qastaging/~mterry/ubuntu-system-settings/wizard-introspection-rtm
Merge into: lp://qastaging/ubuntu-system-settings/rtm-14.09
Diff against target: 51 lines (+23/-2)
2 files modified
wizard/main.cpp (+17/-0)
wizard/ubuntu-system-settings-wizard.conf (+6/-2)
To merge this branch: bzr merge lp://qastaging/~mterry/ubuntu-system-settings/wizard-introspection-rtm
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+243852@code.qastaging.launchpad.net

Commit message

Allow autopilot introspection of the wizard.

Description of the change

Allow autopilot introspection of the wizard.

To test this, you can restart the wizard with introspection:

stop ubuntu-system-settings-wizard WIZARD_DONT_RESUME_UNITY=1
start ubuntu-system-settings-wizard QT_LOAD_TESTABILITY=1

And run a simple script like so to verify introspection works:

$ cat test.py
from autopilot.introspection import get_proxy_object_for_existing_process
import sys
print get_proxy_object_for_existing_process(pid=int(sys.argv[1]))
$ python test.py `pidof system-settings-wizard`

== Checklist ==

 * Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
 Yes

 * Did you build your software in a clean sbuild/pbuilder chroot or ppa?
 Yes

 * Did you build your software in a clean sbuild/pbuilder armhf chroot or ppa?
 Yes

 * Has your component "TestPlan” been executed successfully on emulator, N4?
 Yes

 * Has a 5 minute exploratory testing run been executed on N4?
 Yes

 * If you changed the packaging (debian), did you subscribe a core-dev to this MP?
 NA

 * If you changed the UI, did you subscribe the design-reviewers to this MP?
 NA

 * What components might get impacted by your changes?
 Just wizard

 * Have you requested review by the teams of these owning components?
 Yes

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Great!

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems like we are not doing more rtm landing, so cleaning the list a bit, that one is rather going to be including with the vivid rebase

Unmerged revisions

942. By Michael Terry

Allow testability for the wizard

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches