Merge lp://qastaging/~mterry/unity-greeter/background-file into lp://qastaging/~robert-ancell/unity-greeter/trunk
Proposed by
Michael Terry
Status: | Merged |
---|---|
Approved by: | Robert Ancell |
Approved revision: | 239 |
Merged at revision: | 239 |
Proposed branch: | lp://qastaging/~mterry/unity-greeter/background-file |
Merge into: | lp://qastaging/~robert-ancell/unity-greeter/trunk |
Diff against target: |
194 lines (+32/-17) 2 files modified
src/unity-greeter.vala (+7/-8) src/user-list.vala (+25/-9) |
To merge this branch: | bzr merge lp://qastaging/~mterry/unity-greeter/background-file |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Approve | ||
Review via email:
|
Description of the change
Use background info from liblightdm-gobject if available.
To post a comment you must log in.
Looks good, I'd just change:
unowned string background = default_background;
to
var background = default_background;
(we're not gaining anything by making it unowned)
and the spacing should be four spaces here:
11 + if (user.background != null)
12 + background = user.background;
Feel free to commit with those changes