Unity

Merge lp://qastaging/~mterry/unity/fix-crash-727788 into lp://qastaging/unity

  1. fix-crash-727788
  2. Merge into trunk
Proposed by Michael Terry
Status: Rejected
Rejected by: Didier Roche-Tolomelli
Proposed branch: lp://qastaging/~mterry/unity/fix-crash-727788
Merge into: lp://qastaging/unity
Diff against target: 30 lines (+3/-3)
1 file modified
services/panel-indicator-entry-accessible.c (+3/-3)
To merge this branch: bzr merge lp://qastaging/~mterry/unity/fix-crash-727788
Reviewer Review Type Date Requested Status
Rodrigo Moya (community) Disapprove
Review via email: mp+51897@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

This fix is wrong, the problem is the call to atk_object_notify_state_change, which shouldn't be there. It's already fixed in this other branch: https://code.launchpad.net/~rodrigo-moya/unity/sync-geometries/+merge/51929 which removes that call

review: Disapprove
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Syncing the state to rejected to clean the list

Unmerged revisions

918. By Michael Terry

make PanelIndicatorEntryAccessible's finalize into dispose to fix crashes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.