Merge lp://qastaging/~mterry/unity8-desktop-session/accountsservice into lp://qastaging/unity8-desktop-session

Proposed by Michael Terry
Status: Merged
Approved by: Christopher Townsend
Approved revision: 106
Merged at revision: 109
Proposed branch: lp://qastaging/~mterry/unity8-desktop-session/accountsservice
Merge into: lp://qastaging/unity8-desktop-session
Diff against target: 31 lines (+27/-0)
1 file modified
debian/unity8-session-snap.links (+27/-0)
To merge this branch: bzr merge lp://qastaging/~mterry/unity8-desktop-session/accountsservice
Reviewer Review Type Date Requested Status
Stephen M. Webb (community) Approve
Christopher Townsend (community) Approve
Review via email: mp+310005@code.qastaging.launchpad.net

Commit message

Point the system AccountsService daemon at our registered custom properties.

Description of the change

Add links so that the system AccountsService daemon knows about the custom properties that unity8 wants to register (but those files normally live in the snap, which the system AS daemon can't find).

So we link to it from our glue package. In an all-snaps world, we'll need to add a new interface hook for a new AS system snap. We'll figure that out later, but this is a decent fix for the classic desktop.

I've named the files so that they won't conflict if you have unity8 packages separately installed. The content of the files may conflict (like if the snap adds a new property and the debs don't) -- I'm not sure what would happen in that case. But we eventually plan for these to conflict anyway, so I don't think that's a problem.

To post a comment you must log in.
Revision history for this message
Christopher Townsend (townsend) wrote :

I'm also concerned about the interaction between the snap and deb versions conflicting, but until we have a proper AccountServices snap w/ an interface, this is the best we can do.

I'll approve with my caveat mentioned:)

review: Approve
Revision history for this message
Stephen M. Webb (bregma) wrote :

Agree with ChrisTownsend's comment.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches