Merge lp://qastaging/~mterry/unity8/greeter-focus into lp://qastaging/unity8
| Status: | Merged |
|---|---|
| Approved by: | Daniel d'Andrada |
| Approved revision: | 2007 |
| Merged at revision: | 2540 |
| Proposed branch: | lp://qastaging/~mterry/unity8/greeter-focus |
| Merge into: | lp://qastaging/unity8 |
| Prerequisite: | lp://qastaging/~mterry/unity8/greeter-hide-indicators |
| Diff against target: |
880 lines (+249/-98) 14 files modified
qml/Greeter/Greeter.qml (+28/-24) qml/Greeter/GreeterPrompt.qml (+68/-13) qml/Greeter/LoginList.qml (+27/-16) qml/Greeter/NarrowView.qml (+2/-1) qml/Greeter/WideView.qml (+5/-4) qml/Shell.qml (+5/-3) tests/qmltests/Dash/tst_DashShell.qml (+6/-0) tests/qmltests/Greeter/TestView.qml (+0/-1) tests/qmltests/Greeter/tst_Greeter.qml (+3/-13) tests/qmltests/Greeter/tst_WideView.qml (+92/-12) tests/qmltests/Tutorial/tst_Tutorial.qml (+1/-1) tests/qmltests/tst_OrientedShell.qml (+2/-2) tests/qmltests/tst_Shell.qml (+3/-3) tests/qmltests/tst_ShellWithPin.qml (+7/-5) |
| To merge this branch: | bzr merge lp://qastaging/~mterry/unity8/greeter-focus |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
| Daniel d'Andrada (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2016-06-30.
Commit message
Fix tablet greeter focus to be always-on, no longer hiding the OSK or forcing a mouse click to type a password.
I've also squeezed some other small fixes in:
- Support Up and Down keys in user list.
- Don't accept non-digit characters when prompting for passcode (we ask OSK to show only digits, but due to bug 1586435, it shows other characters too; plus if the user has an external keyboard, they can type anything anyway).
- When prompting for a passcode in wide-view (tablet/desktop), stop at 4 digits just like we do in narrow-view.
- Don't show "Retry" during brief period before a prompt comes in from PAM.
- Don't let user drag user list if there's only one entry.
Now as for the focus changes...
One of the big reasons we lost keyboard focus before was because we set the shell to disabled whenever the greeter was "between PAM events" -- mostly so that the user can't swipe away greeter before we get our first prompt or are otherwise unsure about exactly what authentication is needed.
But disabled qml items can't be focused. So I've rejiggered things a bit. Instead of disabling the whole shell, I just disable the launcher, the indicators, and make the greeter non-swipeable.
I also do some tricks with the prompt so that it looks disabled (while we check with PAM about the password) but isn't actually. I don't want to make it look to the user that pressing backspace while they wait for PAM does anything, so after the user presses Enter, I present a fake label on top of the prompt that looks like a disabled prompt, while simultaneously hiding the prompt contents.
Description of the change
You could mostly just test this on your desktop. Changes are all to the wide-view side of things.
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
NA
* If you changed the UI, has there been a design review?
NA
| Michael Terry (mterry) wrote | # |
| Michael Terry (mterry) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Daniel d'Andrada (dandrader) wrote | # |
| Michael Terry (mterry) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Michael Terry (mterry) wrote | # |
| Daniel d'Andrada (dandrader) wrote | # |
| Michael Terry (mterry) wrote | # |
| Daniel d'Andrada (dandrader) wrote | # |
| Michael Terry (mterry) wrote | # |
| Daniel d'Andrada (dandrader) wrote | # |
| Daniel d'Andrada (dandrader) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
| Daniel d'Andrada (dandrader) wrote | # |
| Michael Terry (mterry) wrote | # |
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
I'm going to work on some qmltests now, but this branch can be reviewed and tested in meantime.