Merge lp://qastaging/~mterry/unity8/greeter-prompt-model into lp://qastaging/unity8

Proposed by Michael Terry
Status: Superseded
Proposed branch: lp://qastaging/~mterry/unity8/greeter-prompt-model
Merge into: lp://qastaging/unity8
Prerequisite: lp://qastaging/~mterry/unity8/greeter-guest
Diff against target: 2521 lines (+903/-525)
29 files modified
plugins/LightDM/CMakeLists.txt (+1/-0)
plugins/LightDM/DBusGreeterList.cpp (+3/-3)
plugins/LightDM/DBusGreeterList.h (+1/-1)
plugins/LightDM/Greeter.cpp (+65/-21)
plugins/LightDM/Greeter.h (+5/-6)
plugins/LightDM/GreeterPrivate.h (+5/-2)
plugins/LightDM/PromptsModel.cpp (+97/-0)
plugins/LightDM/PromptsModel.h (+72/-0)
plugins/LightDM/plugin.cpp (+9/-2)
qml/Greeter/Circle.qml (+1/-1)
qml/Greeter/FullLightDMImpl.qml (+1/-0)
qml/Greeter/Greeter.qml (+31/-61)
qml/Greeter/GreeterPrompt.qml (+29/-31)
qml/Greeter/IntegratedLightDMImpl.qml (+1/-0)
qml/Greeter/LightDMService.qml (+1/-0)
qml/Greeter/LoginList.qml (+35/-110)
qml/Greeter/NarrowView.qml (+11/-21)
qml/Greeter/PromptList.qml (+148/-0)
qml/Greeter/WideView.qml (+5/-15)
tests/mocks/AccountsService/CMakeLists.txt (+1/-0)
tests/mocks/liblightdm/MockGreeter.cpp (+47/-7)
tests/mocks/liblightdm/MockUsersModel.cpp (+5/-0)
tests/plugins/LightDM/IntegratedLightDM/CMakeLists.txt (+26/-0)
tests/plugins/LightDM/IntegratedLightDM/promptsmodel.cpp (+175/-0)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Greeter/TestView.qml (+6/-16)
tests/qmltests/Greeter/tst_Greeter.qml (+22/-102)
tests/qmltests/Greeter/tst_NarrowView.qml (+11/-41)
tests/qmltests/Greeter/tst_WideView.qml (+88/-85)
To merge this branch: bzr merge lp://qastaging/~mterry/unity8/greeter-prompt-model
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Unity Team Pending
Review via email: mp+305652@code.qastaging.launchpad.net

Commit message

Use a model for PAM prompts, supporting more possible interactions.

- This lets us show more than one message and more than one prompt from PAM.

- We now also show error text when a user enters a wrong password. This matches unity7-greeter behavior.

- Similarly, when a fingerprint login is attempted, but we are demanding a real login (e.g. the user hasn't logged in before), we now show a message to explain that a bit.

- Simplify the Greeter/View interactions a bit. We no longer need to signal quite as much events, since the view reflects the prompts model directly.

- Fix keyboard focus handling among prompts.

- Update and expand the tests.

Description of the change

The animation for growing or shrinking the login box as more or less prompts are needed is not final. It will be a little nicer (I believe design -- Alex M -- wants the box to just grow upwards) once I can pre-req on the greeter-arrangement branch (i.e. once it's approved).

* Are there any related MPs required for this MP to build/function as expected? Please list.
 No, just the pre-reqs.

 * Did you perform an exploratory manual test run of your code change and any related functionality?
 Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 NA

 * If you changed the UI, has there been a design review?
 NA, except where we match unity7-greeter behavior, which is fine by design.

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2587
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2222/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2923
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1606
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1606
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1606
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2951
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2809
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2809/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2809
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2809/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2809
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2809/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2809
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2809/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2809
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2809/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2809
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2809/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2809
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2809/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2809
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2809/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2809
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2809/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2222/rebuild

review: Needs Fixing (continuous-integration)
2609. By Andrea Cimitan

override some Qt Components definitions so we can have sane default values for flick speeds

Approved by: Albert Astals Cid

2610. By Andrea Cimitan

Elide the label text inside recent searches panel (LP: #1611796)

Approved by: Albert Astals Cid

2611. By Andrea Cimitan

Add a PreviewSingleton module to store some data for previews (LP: #1595235)

Approved by: Albert Astals Cid

2612. By Andrea Cimitan

Use PreviewSingleton for PreviewRatingInput and PreviewCommentInput (LP: #1595235)

Approved by: Albert Astals Cid

2613. By Andrea Cimitan

rework GenericScopeView PullToRefresh test

Approved by: Albert Astals Cid

2614. By Andrea Cimitan

use mouseFlick instead touchFlick for manage_dash_move_current

Approved by: Albert Astals Cid

2615. By Andrea Cimitan

add a couple of waiting tricks for a flaky dash test

Approved by: Albert Astals Cid

2616. By Albert Astals Cid

LVWPH: update clipItem height when list height changes (LP: #1606935)

Approved by: Andrea Cimitan

2617. By Albert Astals Cid

Put the touchdown shape inside a loader

We only create the shape when needed, saving a bit of CPU time when we're just scrolling around the scopes

Doesn't seem to make the touchdown appear time on press noticeably slower

Approved by: Andrea Cimitan, Josh Arenson, Michael Terry, Unity8 CI Bot

2618. By Albert Astals Cid

No need for the touchdown in the card for the cardtool

We only use that card to get some size measurements so the touchdown code adds nothing

Approved by: Andrea Cimitan

2619. By Albert Astals Cid

Add bottom gradient to the Show Less floating button

Approved by: Andrea Cimitan

2620. By Albert Astals Cid

Remove artShapeSize from non cardtool cards

artShapeSize is only used in the cardtool card to read the value them we pass down in fixedArtShapeSize

According to qmlprofiler evaluating this useless binding accounts for ~0.5% when scrolling up and down a very long scope

Approved by: Andrea Cimitan

2621. By Albert Astals Cid

LVWPH: Fix case in which header was shown incorrectly

Making the list smaller did not move the header so it ended up being in view

Approved by: Josh Arenson

2622. By Albert Astals Cid

LVWPH: Fix items cut on top in the dash (or at least some instances of it)

This reverts a workaround for tests failing introduced in r2121

The commit log of that revision says "The other solutions involve implementing maxYExtent"
which we actually implemented in r2351 so the workaround would not seem needed anymore
and on top of it is causing brokenness so remove it

Approved by: Josh Arenson

2623. By Albert Astals Cid

Reduce calls to CardCreatorCache.getCardComponent while the component is being created

As it is right now on the phone we do calls with empty cardTool.artShapeStyle and cardTool.categoryLayout
that are useless so protect against it to save time. This is not reproducible on the desktop (there's a different Qt though 5.6 vs 5.4) (LP: #1615675)

Approved by: Andrea Cimitan

2624. By Albert Astals Cid

Dash::test_cardIconStyle change compare into tryCompareFunction

On very slow machines (CI or valgrind) the UCProportionalShape is not created immediately so give it some slack

Approved by: Andrea Cimitan

2625. By Albert Astals Cid

Make PreviewActionsTest::test_comboButton more stable

We also wait for the buttonGroup height to have settled otherwise the mouse clicks can end up in the wrong place

Approved by: Andrea Cimitan

2626. By Albert Astals Cid

Adapt onShiftedContentXChanged to work when the content changes very abruptly

This happens in CI quite a bit (and locally when run under xvfb)

Approved by: Michael Zanetti

2627. By Albert Astals Cid

Make tryGenericScopeView show the scope correctly

Approved by: Andrea Cimitan

2628. By Albert Astals Cid

Make sure the spinner does not get too close to the title text (LP: #1597392)

Approved by: Lukáš Tinkl

2629. By Albert Astals Cid

Show "Pull to refresh" in white when overlaid in low luminance colors (LP: #1596849)

Approved by: Michael Terry

2630. By Josh Arenson

Add a frontend to the sessions model and enable a session chooser in the greeter.

Approved by: Michael Terry

2631. By Michael Terry

Support launching apps inside a unity8 session from the greeter and support emergency dialing inside the greeter.

2632. By Michael Terry

Fix tryShell to actually show appropriate backgrounds for each mock user.

Approved by: Albert Astals Cid

2633. By Michael Terry

Add an indicator to the greeter when a user is logged in (only shown if we have more than one user)

Approved by: Albert Astals Cid

2634. By Michael Terry

Hide the greeter OSK if indicators are open and don't show the edge tutorial during an emergency call.

Approved by: Albert Astals Cid

2635. By Michael Terry

Switch from lockscreen PIN pad to a passcode entry box that uses the OSK.

Approved by: Albert Astals Cid

2636. By Michael Terry

Use the default system wallpaper instead of our custom one.

Additionally, crop the default wallpaper instead of rotating it, only darken the wallpaper if it's not the default one, and avoid reloading the wallpaper when the device is rotated.

2637. By Daniel d'Andrada

Set progress bar indeterminate when processing signal received. (LP: #1249349)

Approved by: Daniel d'Andrada

2638. By Daniel d'Andrada

Implement cursor confinement (LP: #1590099)

Approved by: Lukáš Tinkl

2639. By Lukáš Tinkl

Implement edge maximizing (aka window snapping) (LP: #1602628)

Approved by: Daniel d'Andrada

2640. By Albert Astals Cid

Make test_Shell non ultra slow again

By setting the timeout to 0 to findChild we know may return null (LP: #1597366)

Approved by: Lukáš Tinkl, Michael Zanetti

2641. By Albert Astals Cid

Improve findChild calls inside tryCompareFunction.

findChild has a timeout retry since a while ago. This means that if we have a findChild inside a tryCompareFunction the retries multiply and it takes around 30 minutes for the tryCompareFunction to fail if the findChild is failing, so what we do is set the timeout of findChild to 0.

In other cases we just had a tryCompareFunction that made sure the findChild after it would succeed, since now findChild has a retry mechanism we can just remove that tryCompareFunction altogether.

Approved by: Michał Sawicz, Unity8 CI Bot

2642. By Lukáš Tinkl

On the PC platform (as opposed to running on $devices), use the "mute" action instead of silent mode

Approved by: Albert Astals Cid, Unity8 CI Bot

2643. By Lukáš Tinkl

Respect Fitt's law wrt the window control buttons in panel (LP: #1611959)

Approved by: Albert Astals Cid

2644. By Lukáš Tinkl

Fix 2 failing color-related tests

Approved by: Michał Sawicz

2645. By Michael Terry

Update look of infographic a bit

Approved by: Albert Astals Cid

2646. By Michael Terry

Make infographic bubbles white even on the default wallpaper.

Approved by: Albert Astals Cid

2647. By Marco Trevisan (Treviño)

Indicators, mocks: add fake indicators menuitem to populate mocks with different menu types

Also allow to use fake indicators model in IndicatorsClient

Approved by: Albert Astals Cid, Lukáš Tinkl

2648. By Marco Trevisan (Treviño)

IndicatorsClient: use PageHeader and ListItemLayout's

Approved by: Albert Astals Cid

2649. By CI Train Bot Account

Releasing 8.14+16.10.20160922-0ubuntu1

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2588
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2235/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2940
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1621
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1621
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1621
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2968
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2826
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2826/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2826
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2826/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2826
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2826/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2826
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2826/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2826
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2826/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2826
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2826/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2826
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2826/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2826
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2826/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2826
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2826/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2235/rebuild

review: Needs Fixing (continuous-integration)
2650. By CI Train Bot Account

Resync trunk.

2651. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2652. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2589
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2272/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2993
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1654
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1654
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1654
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3021
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2878
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2878/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2878
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2878/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2878
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2878/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2878
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2878/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2878
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2878/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2878
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2878/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2878
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2878/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2878
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2878/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2878
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2878/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2272/rebuild

review: Needs Fixing (continuous-integration)
2653. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2654. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2655. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2656. By Michael Terry

* debian/control:
  - Drop unity-scope-mediascanner2 to a Suggests rather than a Recommends,
    to ease our transition to main. It's already seeded directly in
    Touch, so this will only affect the Desktop variant of unity8.

2657. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2658. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2659. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2660. By Michael Terry

Grab launcher icon information from ubuntu-app-launch, not directly from desktop files.

Approved by: Michael Zanetti

2661. By Michael Terry

Adjust root paths if we're running inside a snap. (LP: #1629009)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2662. By Michael Zanetti

Merge all Stages into one single codebase. Apply new spread visuals.

This deletes PhoneStage, TabletStage and DesktopStage, and merges all of the functionality into Stage. Also the spread visuals have been updated by design to work with all usage modes. (LP: #1489517, #1603914, #1635800)

Approved by: Lukáš Tinkl

2663. By Lukáš Tinkl

Restore the double tap decoration to maximize feature (LP: #1627281)

Approved by: Michael Zanetti

2664. By Andrea Azzarone

Remove UbuntuShapeForItem and replace its use with the more standard Ubuntu.Components.UbuntuShape.

Approved by: Albert Astals Cid, Lukáš Tinkl

2665. By Lukáš Tinkl

Hide the cursor for fullscreen apps after 3 seconds of inactivity

Approved by: Albert Astals Cid

2666. By Albert Astals Cid

Make PreviewProgress be thicker again

Last UITK landing reverted us to a very thin line, the code was a bit weird in which we both set implicitHeight and height in a bit of almost recursive fasion.

Make it simpler by just setting the height (LP: #1629382)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2667. By Marco Trevisan (Treviño)

MenuItemFactory: use more features from SlotsLayout based settings components

Remove some legacy elements that were needed before

Approved by: Albert Astals Cid

2668. By Lukáš Tinkl

Implement moving windows by Alt + left mouse button

Approved by: Daniel d'Andrada

2669. By Albert Astals Cid

tst_PreviewZoomableImage: Wait for LazyImage transitions on init() (LP: #1630136)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2670. By CI Train Bot Account

Releasing 8.14+17.04.20161024-0ubuntu1

2671. By Marco Trevisan (Treviño)

MenuItemFactory: activate item on calendar selection change

This informs the indicator-datetime to update the list of the upcoming events (LP: #1541125)

Approved by: Lukáš Tinkl

2672. By CI Train Bot Account

Releasing 8.14+17.04.20161027-0ubuntu1

2673. By CI Train Bot Account

Resync trunk.

2674. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2675. By Andrea Cimitan

Remove background under header pagination dots, update dots assets, remove dash paper background, update bottom edge asset

Approved by: Albert Astals Cid, Unity8 CI Bot

2676. By Albert Astals Cid

Make more CardTool properties readonly

This removes "hacks" from GenericScopeView and moves them to either CardTool or CardGrid in a less "this is a hack" way

Approved by: Andrea Cimitan, Unity8 CI Bot

2677. By Andrea Cimitan

Few styling changes for cards

Approved by: Albert Astals Cid, Unity8 CI Bot

2678. By Albert Astals Cid

Make the > in Dash Section Header be after text

Instead than at the right of the view (LP: #1508905)

Approved by: Andrea Cimitan

2679. By Albert Astals Cid

Rework Dash Preview column margins

    If there's one column
     Preview widgets have 2GU on each side
      Unless it's one of the "full screen" widgets, i.e. video/image
     This hasn't changed in this patch

    If there's two columns
     the columns have 4GU on each side and between eachother
     This has changed according to design guidelines

Approved by: Andrea Cimitan, Unity8 CI Bot

2680. By Albert Astals Cid

Improve LVWPH <-> GenericScopeView interaction

Send up directly the delegate instead of the delegateIndex and then asking back for the delegate

Saves time and also if the delegateIndex is the same number but the delegate different the delegate won't be updated because QML doesn't know it's different (LP: #1508905, #1622423)

Approved by: Michael Zanetti, Paweł Stołowski, Unity8 CI Bot

2681. By Albert Astals Cid

Make the PreviewButtons be of the width of the button and not half the total width

half the total width is still the max width and the combos are still all the same width

Approved by: Andrea Cimitan, Unity8 CI Bot

2682. By Andrea Cimitan

various tweaks to fonts inside previews

Approved by: Albert Astals Cid

2683. By Albert Astals Cid

Fix first column of the preview table to be 25%

This way two consecutive tables have the second column start at the same X coordinate

Approved by: Andrea Cimitan

2684. By Andrea Cimitan

More visual tweaks

Approved by: Albert Astals Cid

2685. By Michael Terry

More path lookup fixes for running inside of a snap. (LP: #1629009)

Approved by: Michael Zanetti, Unity8 CI Bot

2686. By Michael Zanetti

Added blur and darkening to wallpaper while in spread

Approved by: Lukáš Tinkl

2687. By Michael Zanetti

Fixes in the spread after design review

- add a minimum width for the tile info to prevent it going to ...
- tiles should not be interactive any more when moving to spread
- add some resistance to the drag when an app is not closeable
- allow rotating when there is no app focused
- add a fade in animation to the icons in the spread
- fix spread looking out of place when there's only one item (LP: #1637502, #1638848)

Approved by: Lukáš Tinkl

2688. By Michael Zanetti

More fixes to the unified stages code (LP: #1637205, #1637249, #1637258)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2689. By Michael Zanetti

Delay alt tab for tiny bit in order to avoid flickering on quick alt-tabs

Approved by: Lukáš Tinkl

2690. By Lukáš Tinkl

Stabilize test_doubleTapToMaximizeWindow()

Approved by: Michael Zanetti, Unity8 CI Bot

2691. By Brian Douglass

Add a new setting to enable/disable the launcher

Approved by: Michael Zanetti

2692. By Tomás Tormo

Reload Infographics userdata when the day changes (LP: #1378814)

Approved by: Albert Astals Cid

2693. By Lukáš Tinkl

Enable loading the main Qt catalog which in turn allows for using RTL languages

Approved by: Albert Astals Cid

2694. By Lukáš Tinkl

Fix the pixelated notification icon by setting sourceSize (LP: #1637712)

Approved by: Michael Zanetti, Unity8 CI Bot

2695. By CI Train Bot Account

Releasing 8.14+17.04.20161109-0ubuntu1

Revision history for this message
Albert Astals Cid (aacid) wrote :

putting this as WiP as the parent is also set as WiP

2696. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2697. By Michael Zanetti

Stabilize OrientedShell tests

Approved by: Lukáš Tinkl, Unity8 CI Bot

2698. By CI Train Bot Account

* MenuItemFactory: bind calendar backend properties to calendarMenu item
  Adds support for showing the calendar at the requested date, marking days
  with events properly and toggling the visibility of the week number.
* Bump version as USC breaks with unity8 << 8.14

2699. By CI Train Bot Account

MenuItemFactory: use Menus.RadioMenu and Menus.ButtonMenu

2700. By Marco Trevisan (Treviño)

testLauncher: use tryCompare to check launcher contentY

Also init the launcher before each test

Approved by: Albert Astals Cid, Lukáš Tinkl, Unity8 CI Bot

2701. By Albert Astals Cid

[Hopefully] Fix infinite loop in some of the GSV tests

Potentially this could happen in real life too

Given rounding issues sometimes we ended up in a loop of showing the floatingSeeLess,
this makes the ScopeListView shorter which ends up in recalculation of whether floatingSeeLess
should be visible which then meant no and loop forever.

With this change i've run the test for 24 hours without it being stuck when previously it got stuck each 2 hours aprox (LP: #1599301)

Approved by: Michał Sawicz

2702. By CI Train Bot Account

Releasing 8.15+17.04.20161116.1-0ubuntu1

2703. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2704. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2705. By Andrea Cimitan

Fix white text (LP: #1644468)

Approved by: Albert Astals Cid, Unity8 CI Bot

2706. By Andrea Cimitan

Make MascotLoader in CardCreator flat

Approved by: Albert Astals Cid, Unity8 CI Bot

2707. By Andrea Cimitan

Make the remaining UbuntuShape flat

Approved by: Albert Astals Cid, Unity8 CI Bot

2708. By Andrea Cimitan

added dropshadow from panel indicators to dash page header extra panel, so there is right shadow when the extra panel is narrow

Approved by: Albert Astals Cid, Unity8 CI Bot

2709. By Andrea Cimitan

Look up for expandable template dash category flag

Approved by: Albert Astals Cid, Unity8 CI Bot

2710. By Albert Astals Cid

Fix PreviewProgress implicitHeight

We actually want this to be the height of the progressbar that we fix so use that and not the implicitHeight (LP: #1641943)

Approved by: Andrea Cimitan, Unity8 CI Bot

2711. By Andrea Azzarone

Set Mir.cursorName to "grabbing" on first mouse press on a window decoration. Don't wait for press+motion. (LP: #1618078)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2712. By Andrea Azzarone

Do not show a divider between each quicklist entry but just between each section, similar to how unity7 does. (LP: #1637478)

Approved by: Albert Astals Cid, Unity8 CI Bot

2713. By Daniel d'Andrada

There's no need for WindowDecoration to access the appDelegate

It damages modularity.

Approved by: Michael Zanetti, Unity8 CI Bot

2714. By Brian Douglass

Added a setting to enable/disable the indicator dropdown menu.

Approved by: Michael Zanetti, Unity8 CI Bot

2715. By Michael Zanetti

disable spread interaction while locked (LP: #1641578)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2716. By Olivier Tilloy

Remove dependency on transitional package. (LP: #1583079)

Approved by: Albert Astals Cid, Unity8 CI Bot

2717. By Lukáš Tinkl

Enable brightness (laptop backlight) handling on desktop/laptop PCs (LP: #1595947)

Approved by: Michael Zanetti, Unity8 CI Bot

2718. By Andrea Azzarone

Implement launcher tooltips.

Approved by: Michał Sawicz

2719. By Albert Astals Cid

Adapt to dummy notification being gone

and warning fix as bonus

Approved by: Lukáš Tinkl, Unity8 CI Bot

2720. By Albert Astals Cid

Fix autopilot test_lock_screen tests

Approved by: Andrea Cimitan, Unity8 CI Bot

2721. By Albert Astals Cid

Autopilot: Add more applications to the list for wider screens

Otherwise the test was failing because available_applications was too short

Approved by: Andrea Cimitan, Unity8 CI Bot

2722. By Albert Astals Cid

Fix autopilot DashHelperTestCase.test_search

Approved by: Andrea Cimitan, Unity8 CI Bot

2723. By Albert Astals Cid

Also install the Screens mock

This way we can run some more autopilot tests in X11

Approved by: Lukáš Tinkl, Unity8 CI Bot

2724. By Albert Astals Cid

Give default value to gu-px size

Fixes some of the autopilot greeter tests when run under X11

Approved by: Andrea Cimitan, Unity8 CI Bot

2725. By CI Train Bot Account

Releasing 8.15+17.04.20161129-0ubuntu1

2726. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2727. By Lukáš Tinkl

Fix the Super key not invoking the dash scope home (LP: #1607427)

Approved by: Daniel d'Andrada, Unity8 CI Bot

2728. By Albert Astals Cid

Add the Wsuggest-override flag to gcc

While at it mark system includes as such so we don't get warnings we can not fix

Approved by: Michael Zanetti, Unity8 CI Bot

2729. By Albert Astals Cid

Add support for compiler sanitizers via ECM

2730. By Albert Astals Cid

Use timeStep as delay time

Passing iterations / speed didn't make much sense since that parameter is a delay in milliseconds and the default parameters would give a value of 5 / units.gu(10) that is smaller than 1 millisecond.

Qt 5.7 calculation for velocity was very unhappy if we moved things so fast in less than 1ms and ignored the movements, so this also makes tests pass on Qt 5.7 (LP: #1642919)

Approved by: Josh Arenson, Unity8 CI Bot

2731. By Michael Zanetti

Add the ApplicationDrawer

Approved by: Lukáš Tinkl, Unity8 CI Bot

2732. By Michael Zanetti

tune right edge push

make it less intrusive when accidentally hitting the edge with the mouse
tweak visuals for the mouse case (LP: #1646094)

Approved by: Unity8 CI Bot

2733. By Michael Zanetti

improve close button visiblity when hovering with the mouse

Approved by: Albert Astals Cid, Unity8 CI Bot

2734. By Albert Astals Cid

Bring back fix for 1517830

Now with autotest \o/ (LP: #1517830)

Approved by: Andrea Cimitan, Unity8 CI Bot

2735. By Daniel d'Andrada

Fix "make tryApplicationWindow"

No surface was showing up on the screen
Also remove outdated button (feature is no longer there)

Approved by: Albert Astals Cid, Unity8 CI Bot

2736. By Albert Astals Cid

Fix compile warnings in mocks

Approved by: Daniel d'Andrada, Unity8 CI Bot

2737. By Josh Arenson

Enable the greeter to remember which session the user last logged into

This also fixes a small issue with how the default session was handled. (LP: #1631365)

Approved by: Albert Astals Cid, Unity8 CI Bot

2738. By Daniel d'Andrada

Take save/restore functions out of WindowResizeArea

They've no relationship with resizing whatsoever.

Approved by: Lukáš Tinkl, Unity8 CI Bot

2739. By Michael Zanetti

Update virtual touchpad visuals and add a tutorial. (LP: #1585220)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2740. By Albert Astals Cid

Do not hide panel when launching an application if the mouse is on the panel

Need Functions.itemUnderMouse because MouseArea.containsMouse returns true when tapping (i.e. no mouse used) on it.

Unfortunately the QML testlib do not set the proper value when issueing a mouseMove so i can't add a test that proofs it works, i'll try to propose something upstream and then add the test at a later MR (LP: #1591311)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2741. By Pete Woods

MenuItemFactory: Add subtitle support to SwitchItem widget

Approved by: Marco Trevisan (Treviño), Michał Sawicz, Unity8 CI Bot

2742. By CI Train Bot Account

Releasing 8.15+17.04.20161207.1-0ubuntu1

2743. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2744. By Michael Terry

Refactor our lightdm mock

2745. By Michael Terry

Add support for lightdm guest users

2746. By Michael Terry

Merge from simple-lightdm-mock

2747. By Michael Terry

Fix tests

2748. By Michael Terry

Add a couple more data roles for guest

2749. By Michael Terry

Move extra items inside MangleModel, which is now a simple identity proxy, to avoid confusing the sort proxy model and thus avoid crashes

2750. By Michael Terry

Add a touch more testing

2751. By Michael Terry

Right, you don't need to guard delete

2752. By Michael Terry

Have mock notice when we suddenly gain or lose a guest account, fixing a test

2753. By Michael Terry

First pass at a prompts model

2754. By Michael Terry

Properly fade in new prompts; don't show double prompts when using mocks

2755. By Michael Terry

Merge greeter-guest

2756. By Michael Terry

fix some tests

2757. By Michael Terry

Merge greeter-guest

2758. By Michael Terry

Fix more tests

2759. By Michael Terry

Fix tests

2760. By Michael Terry

Switch to new Q_ENUM macro

2761. By Michael Terry

Merge greeter-manual-login

2762. By Michael Terry

Make sure that greeter prompt buttons are in focus chain too

2763. By Michael Terry

Merge greeter-manual-login

2764. By Michael Terry

Fix some tests that broke with new manual login pre-req

2765. By Michael Terry

Fix up session test a bit, which also lets it pass

2766. By Michael Terry

Fix first session icon on startup

2767. By Michael Terry

Make sure to reset binding unconditionally during test init; in some cases when running a test in isolation, things wouldn't be set up correctly

2768. By Michael Terry

Add some safeguards to the WideView test, to avoid the test starting before the UI is ready; hopefully fixes a flaky test

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches