Merge lp://qastaging/~mterry/unity8/mir-startup into lp://qastaging/unity8

Proposed by Michael Terry
Status: Merged
Approved by: Michael Zanetti
Approved revision: 2807
Merged at revision: 2846
Proposed branch: lp://qastaging/~mterry/unity8/mir-startup
Merge into: lp://qastaging/unity8
Diff against target: 90 lines (+19/-35)
1 file modified
data/unity8.conf (+19/-35)
To merge this branch: bzr merge lp://qastaging/~mterry/unity8/mir-startup
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
Unity8 CI Bot continuous-integration Approve
Review via email: mp+316719@code.qastaging.launchpad.net

Commit message

Simplify our startup handling of Mir environment variables and set the right socket path in snappy.

Description of the change

Simplify our startup handling of Mir environment variables and set the right socket path in snappy.

The old code set up a bunch of Mir variables in the pre-start section, guarded by [ -n "$MIR_SOCKET" ]. This was designed to tell if we were running under Mir or X (we used to support both). Since that time, lightdm stopped setting MIR_SOCKET to tell us we were in Mir and started setting MIR_SERVER_HOST_SOCKET instead.

So for a while now, that whole Mir section was not being run at all. This didn't matter so much because at some point, the default value for the Mir client socket became what we were setting in that section anyway.

(We also grew a code block in the post-start that duplicated some of the never-run block in the pre-start.)

So you could think that maybe we could just drop that block entirely. However, now with snappy, we want to put our socket in the hardcoded path /run/user/XXX/mir_socket, not respecting XDG_RUNTIME_DIR. This is because the 'mir' interface specifies that path as the socket to use. And XDG_RUNTIME_DIR is a namespaced directory, not the normal /run/user/XXX/ path.

So I've added that logic, and restored the code block that is responsible for passing MIR_SOCKET onto the rest of the session.

(Oh and I also dropped the MIR_CLIENT_INPUT_RATE bit that seemed unused now -- I couldn't find reference to that variable in the Mir source anymore.)

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2807
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3112/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4048
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2372
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2372
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4076
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3917
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3917/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3917
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3917/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3917
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3917/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3917
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3917/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3917
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3917/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3917
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3917/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3112/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

tested, still works fine. changes look good

ci is green

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches