Merge lp://qastaging/~mterry/unity8/mir-startup into lp://qastaging/unity8
Status: | Merged |
---|---|
Approved by: | Michael Zanetti |
Approved revision: | 2807 |
Merged at revision: | 2846 |
Proposed branch: | lp://qastaging/~mterry/unity8/mir-startup |
Merge into: | lp://qastaging/unity8 |
Diff against target: |
90 lines (+19/-35) 1 file modified
data/unity8.conf (+19/-35) |
To merge this branch: | bzr merge lp://qastaging/~mterry/unity8/mir-startup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Zanetti (community) | Approve | ||
Unity8 CI Bot | continuous-integration | Approve | |
Review via email:
|
Commit message
Simplify our startup handling of Mir environment variables and set the right socket path in snappy.
Description of the change
Simplify our startup handling of Mir environment variables and set the right socket path in snappy.
The old code set up a bunch of Mir variables in the pre-start section, guarded by [ -n "$MIR_SOCKET" ]. This was designed to tell if we were running under Mir or X (we used to support both). Since that time, lightdm stopped setting MIR_SOCKET to tell us we were in Mir and started setting MIR_SERVER_
So for a while now, that whole Mir section was not being run at all. This didn't matter so much because at some point, the default value for the Mir client socket became what we were setting in that section anyway.
(We also grew a code block in the post-start that duplicated some of the never-run block in the pre-start.)
So you could think that maybe we could just drop that block entirely. However, now with snappy, we want to put our socket in the hardcoded path /run/user/
So I've added that logic, and restored the code block that is responsible for passing MIR_SOCKET onto the rest of the session.
(Oh and I also dropped the MIR_CLIENT_
PASSED: Continuous integration, rev:2807 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3112/ /unity8- jenkins. ubuntu. com/job/ build/4048 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= xenial+ overlay, testname= qmluitests. sh/2372 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= zesty,testname= qmluitests. sh/2372 /unity8- jenkins. ubuntu. com/job/ build-0- fetch/4076 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 3917 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 3917/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= zesty/3917 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= zesty/3917/ artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 3917 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 3917/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= zesty/3917 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= zesty/3917/ artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 3917 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 3917/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= zesty/3917 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= zesty/3917/ artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3112/ rebuild
https:/