Merge lp://qastaging/~mterry/unity8/session-lightdm into lp://qastaging/unity8
- session-lightdm
- Merge into trunk
Status: | Superseded |
---|---|
Proposed branch: | lp://qastaging/~mterry/unity8/session-lightdm |
Merge into: | lp://qastaging/unity8 |
Prerequisite: | lp://qastaging/~mterry/unity8/infographic-refresh |
Diff against target: |
3487 lines (+296/-2048) 67 files modified
CMakeLists.txt (+1/-0) cmake/modules/QmlTest.cmake (+3/-3) data/unity8.conf (+12/-12) debian/rules (+1/-3) plugins/AccountsService/AccountsService.cpp (+27/-1) plugins/AccountsService/AccountsService.h (+8/-0) plugins/LightDM/CMakeLists.txt (+16/-8) plugins/LightDM/FullLightDM/CMakeLists.txt (+0/-32) plugins/LightDM/IntegratedLightDM/CMakeLists.txt (+0/-33) plugins/LightDM/IntegratedLightDM/QLightDM/Greeter (+0/-17) plugins/LightDM/IntegratedLightDM/QLightDM/SessionsModel (+0/-17) plugins/LightDM/IntegratedLightDM/QLightDM/UsersModel (+0/-17) plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt (+0/-55) plugins/LightDM/IntegratedLightDM/liblightdm/Greeter.cpp (+0/-182) plugins/LightDM/IntegratedLightDM/liblightdm/Greeter.h (+0/-108) plugins/LightDM/IntegratedLightDM/liblightdm/GreeterPrivate.cpp (+0/-309) plugins/LightDM/IntegratedLightDM/liblightdm/GreeterPrivate.h (+0/-52) plugins/LightDM/IntegratedLightDM/liblightdm/SessionsModel.cpp (+0/-87) plugins/LightDM/IntegratedLightDM/liblightdm/SessionsModel.h (+0/-72) plugins/LightDM/IntegratedLightDM/liblightdm/SessionsModelPrivate.cpp (+0/-36) plugins/LightDM/IntegratedLightDM/liblightdm/SessionsModelPrivate.h (+0/-54) plugins/LightDM/IntegratedLightDM/liblightdm/UsersModel.cpp (+0/-110) plugins/LightDM/IntegratedLightDM/liblightdm/UsersModel.h (+0/-66) plugins/LightDM/IntegratedLightDM/liblightdm/UsersModelPrivate.cpp (+0/-94) plugins/LightDM/IntegratedLightDM/liblightdm/UsersModelPrivate.h (+0/-72) plugins/LightDM/IntegratedLightDM/qmldir (+0/-3) plugins/LightDM/plugin.cpp (+8/-21) plugins/LightDM/plugin.h (+1/-1) plugins/LightDM/qmldir (+2/-3) plugins/Unity/Session/dbusunitysessionservice.cpp (+3/-45) plugins/Unity/Session/dbusunitysessionservice.h (+0/-3) qml/Components/Dialogs.qml (+5/-5) qml/Greeter/FullLightDMImpl.qml (+0/-31) qml/Greeter/Greeter.qml (+30/-29) qml/Greeter/IntegratedLightDMImpl.qml (+0/-30) qml/Greeter/LightDMService.qml (+0/-54) qml/Greeter/LoginList.qml (+9/-9) qml/Greeter/NarrowView.qml (+1/-1) qml/Greeter/PromptList.qml (+7/-7) qml/Greeter/SessionsList.qml (+4/-4) qml/Greeter/WideView.qml (+2/-2) qml/Greeter/qmldir (+0/-1) qml/Shell.qml (+8/-1) tests/mocks/AccountsService/AccountsService.cpp (+14/-0) tests/mocks/AccountsService/AccountsService.h (+8/-0) tests/mocks/AccountsService/CMakeLists.txt (+5/-1) tests/mocks/libusermetrics/UserMetrics.cpp (+3/-5) tests/plugins/AccountsService/AccountsServer.cpp (+11/-0) tests/plugins/AccountsService/AccountsServer.h (+5/-0) tests/plugins/AccountsService/client.cpp (+71/-21) tests/plugins/AccountsService/interfaces.xml (+1/-0) tests/plugins/LightDM/CMakeLists.txt (+0/-1) tests/plugins/LightDM/IntegratedLightDM/CMakeLists.txt (+0/-157) tests/plugins/LightDM/IntegratedLightDM/integrated.cpp (+0/-88) tests/plugins/LightDM/IntegratedLightDM/pam.cpp (+0/-54) tests/plugins/LightDM/dbus.cpp (+1/-1) tests/plugins/LightDM/greeter.qml (+1/-1) tests/plugins/Unity/Session/sessionbackendtest.cpp (+0/-1) tests/qmltests/Dash/tst_DashShell.qml (+1/-1) tests/qmltests/Greeter/tst_Greeter.qml (+8/-8) tests/qmltests/Greeter/tst_Infographics.qml (+1/-1) tests/qmltests/Greeter/tst_NarrowView.qml (+4/-4) tests/qmltests/Greeter/tst_WideView.qml (+7/-7) tests/qmltests/Tutorial/tst_Tutorial.qml (+1/-1) tests/qmltests/tst_OrientedShell.qml (+1/-1) tests/qmltests/tst_Shell.qml (+4/-4) tests/qmltests/tst_ShellWithPin.qml (+1/-1) |
To merge this branch: | bzr merge lp://qastaging/~mterry/unity8/session-lightdm |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Needs Fixing | ||
Unity8 CI Bot | continuous-integration | Needs Fixing | |
Josh Arenson | Approve | ||
Review via email:
|
This proposal supersedes a proposal from 2016-07-14.
Commit message
Use liblightdm for session lockscreen too.
This lets us switch users directly from the lockscreen, rather than going to the system greeter.
Description of the change
This is mostly simplification.
- I drop the distinction between FullLightDM and IntegratedLightDM. Now we always use the full lightdm experience. This lets us drop our custom PAM and custom user code in IntegratedLightDM. No more support for ~/.unity8-
- I add a "greeterMode" property to our AccountsService plugin. This toggles whether we try to write non-active user properties back to the system AccountsService daemon or not. When running in-session, we don't want to. We don't have permission to anyway, and it doesn't really matter for the properties we change (notably, the FailedLogins count -- we can just keep track of that locally. It's not urgent that we write that to disk in this case.)
As part of landing, we should backport lightdm from yakkety. Silo 1679 has this MP, a backported lightdm, and the related branches listed below.
FIXME: this needs some more work:
- Needs re-testing after some big merges from trunk that I've done.
- It seems to cause (exacerbate?) a crash when switching between sessions, something to do with VT switches failing...?
- Needs some security work to tag unity8 with an apparmor label and have liblightdm only allow in-session connections that have that label.
======
* Are there any related MPs required for this MP to build/function as expected? Please list.
Yes. Two config changes to enable this new mode:
- https:/
- https:/
And a backported yakkety lightdm.
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
I'm on the team.
* If you changed the UI, has there been a design review?
NA
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2571
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Josh Arenson (josharenson) wrote : | # |
I'm about 75% of the way done reviewing this, but there are some inline issues. I want to discuss something about the mock with you on IRC tomorrow.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Michael Terry (mterry) wrote : | # |
I think I addressed all your inline comments. Thanks!
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2572
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2573
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
FAILURE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2574
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2575
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Josh Arenson (josharenson) wrote : | # |
Found a few unrelated issues while testing this branch, but I'll propose some patches. This branch is fine as is though :-)
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, extensively.
* Did CI run pass? If not, please explain why.
No, unrelated
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2576
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Michael Terry (mterry) wrote : | # |
I've made two changes here that should probably get further sign off from you, Josh.
1) I updated the usage of sessionToStart -- I couldn't figure out how the old logic was supposed to work, but the fallback code seemed busted -- wouldn't ever actually use the default from lightdm. And NarrowView never set a sessionToStart.
2) I updated the upstart job to use MIR_SERVER_
Anyway, you can see the changes in r2578 and r2579.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Michael Terry (mterry) wrote : | # |
You can test this (including backported lightdm for the phone) in silo 1679.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Michael Zanetti (mzanetti) wrote : | # |
I've added this to silo 2022 but when this branch is included it fails to boot.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Michael Terry (mterry) wrote : | # |
Yeah don't add this yet, sorry.
It needs a lot of support (other branches in silo 1679) as well as a backported lightdm (also manually uploaded in silo 1679).
On top of that, I'm trying to confirm with Security about their feelings on actually enabling this LightDM feature.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Albert Astals Cid (aacid) wrote : | # |
breaks Infographics:
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2580
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
- 2703. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2704. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2705. By Andrea Cimitan
-
Fix white text (LP: #1644468)
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2706. By Andrea Cimitan
-
Make MascotLoader in CardCreator flat
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2707. By Andrea Cimitan
-
Make the remaining UbuntuShape flat
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2708. By Andrea Cimitan
-
added dropshadow from panel indicators to dash page header extra panel, so there is right shadow when the extra panel is narrow
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2709. By Andrea Cimitan
-
Look up for expandable template dash category flag
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2710. By Albert Astals Cid
-
Fix PreviewProgress implicitHeight
We actually want this to be the height of the progressbar that we fix so use that and not the implicitHeight (LP: #1641943)
Approved by: Andrea Cimitan, Unity8 CI Bot
- 2711. By Andrea Azzarone
-
Set Mir.cursorName to "grabbing" on first mouse press on a window decoration. Don't wait for press+motion. (LP: #1618078)
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2712. By Andrea Azzarone
-
Do not show a divider between each quicklist entry but just between each section, similar to how unity7 does. (LP: #1637478)
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2713. By Daniel d'Andrada
-
There's no need for WindowDecoration to access the appDelegate
It damages modularity.
Approved by: Michael Zanetti, Unity8 CI Bot
- 2714. By Brian Douglass
-
Added a setting to enable/disable the indicator dropdown menu.
Approved by: Michael Zanetti, Unity8 CI Bot
- 2715. By Michael Zanetti
-
disable spread interaction while locked (LP: #1641578)
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2716. By Olivier Tilloy
-
Remove dependency on transitional package. (LP: #1583079)
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2717. By Lukáš Tinkl
-
Enable brightness (laptop backlight) handling on desktop/laptop PCs (LP: #1595947)
Approved by: Michael Zanetti, Unity8 CI Bot
- 2718. By Andrea Azzarone
-
Implement launcher tooltips.
Approved by: Michał Sawicz
- 2719. By Albert Astals Cid
-
Adapt to dummy notification being gone
and warning fix as bonus
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2720. By Albert Astals Cid
-
Fix autopilot test_lock_screen tests
Approved by: Andrea Cimitan, Unity8 CI Bot
- 2721. By Albert Astals Cid
-
Autopilot: Add more applications to the list for wider screens
Otherwise the test was failing because available_
applications was too short Approved by: Andrea Cimitan, Unity8 CI Bot
- 2722. By Albert Astals Cid
-
Fix autopilot DashHelperTestC
ase.test_ search Approved by: Andrea Cimitan, Unity8 CI Bot
- 2723. By Albert Astals Cid
-
Also install the Screens mock
This way we can run some more autopilot tests in X11
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2724. By Albert Astals Cid
-
Give default value to gu-px size
Fixes some of the autopilot greeter tests when run under X11
Approved by: Andrea Cimitan, Unity8 CI Bot
- 2725. By CI Train Bot Account
-
Releasing 8.15+17.
04.20161129- 0ubuntu1 - 2726. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2727. By Lukáš Tinkl
-
Fix the Super key not invoking the dash scope home (LP: #1607427)
Approved by: Daniel d'Andrada, Unity8 CI Bot
- 2728. By Albert Astals Cid
-
Add the Wsuggest-override flag to gcc
While at it mark system includes as such so we don't get warnings we can not fix
Approved by: Michael Zanetti, Unity8 CI Bot
- 2729. By Albert Astals Cid
-
Add support for compiler sanitizers via ECM
- 2730. By Albert Astals Cid
-
Use timeStep as delay time
Passing iterations / speed didn't make much sense since that parameter is a delay in milliseconds and the default parameters would give a value of 5 / units.gu(10) that is smaller than 1 millisecond.
Qt 5.7 calculation for velocity was very unhappy if we moved things so fast in less than 1ms and ignored the movements, so this also makes tests pass on Qt 5.7 (LP: #1642919)
Approved by: Josh Arenson, Unity8 CI Bot
- 2731. By Michael Zanetti
-
Add the ApplicationDrawer
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2732. By Michael Zanetti
-
tune right edge push
make it less intrusive when accidentally hitting the edge with the mouse
tweak visuals for the mouse case (LP: #1646094)Approved by: Unity8 CI Bot
- 2733. By Michael Zanetti
-
improve close button visiblity when hovering with the mouse
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2734. By Albert Astals Cid
-
Bring back fix for 1517830
Now with autotest \o/ (LP: #1517830)
Approved by: Andrea Cimitan, Unity8 CI Bot
- 2735. By Daniel d'Andrada
-
Fix "make tryApplicationW
indow" No surface was showing up on the screen
Also remove outdated button (feature is no longer there)Approved by: Albert Astals Cid, Unity8 CI Bot
- 2736. By Albert Astals Cid
-
Fix compile warnings in mocks
Approved by: Daniel d'Andrada, Unity8 CI Bot
- 2737. By Josh Arenson
-
Enable the greeter to remember which session the user last logged into
This also fixes a small issue with how the default session was handled. (LP: #1631365)
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2738. By Daniel d'Andrada
-
Take save/restore functions out of WindowResizeArea
They've no relationship with resizing whatsoever.
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2739. By Michael Zanetti
-
Update virtual touchpad visuals and add a tutorial. (LP: #1585220)
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2740. By Albert Astals Cid
-
Do not hide panel when launching an application if the mouse is on the panel
Need Functions.
itemUnderMouse because MouseArea. containsMouse returns true when tapping (i.e. no mouse used) on it. Unfortunately the QML testlib do not set the proper value when issueing a mouseMove so i can't add a test that proofs it works, i'll try to propose something upstream and then add the test at a later MR (LP: #1591311)
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2741. By Pete Woods
-
MenuItemFactory: Add subtitle support to SwitchItem widget
Approved by: Marco Trevisan (Treviño), Michał Sawicz, Unity8 CI Bot
- 2742. By CI Train Bot Account
-
Releasing 8.15+17.
04.20161207. 1-0ubuntu1
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Albert Astals Cid (aacid) wrote : | # |
Conflict: can't delete plugins/
Conflict because plugins/
Contents conflict in plugins/
Text conflict in qml/Greeter/
Text conflict in qml/Greeter/
Contents conflict in tests/mocks/
Conflict adding file tests/mocks/
Contents conflict in tests/mocks/
Conflict adding file tests/mocks/
9 conflicts encountered.
- 2743. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2744. By Daniel d'Andrada
-
Let the model deal with some window management decisions
eg: which window to focus, whether to change surface state
unity8 requests and reacts to changes in the model instead of applying them (LP: #1346633)
Approved by: Emanuele Antonio Faraone, Lukáš Tinkl
- 2745. By CI Train Bot Account
-
Releasing 8.15+17.
04.20161215- 0ubuntu1
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2581
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2581
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Albert Astals Cid (aacid) wrote : | # |
There's a reproduceable test regression in xvfbtestInfogra
- 2746. By CI Train Bot Account
-
Resync trunk.
- 2747. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2748. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2749. By Timo Jyrinki
-
No change rebuild
- 2750. By Michael Terry
-
Run the qmluitests.sh autopkg test against the installed package.
This is faster and more accurate than rebuilding unity8 and running tests from the build dir.
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2751. By Nick Dedekind
-
Added registry for application menus
Approved by: Michael Zanetti, Unity8 CI Bot
- 2752. By Michał Sawicz
-
Application menus
- 2753. By Michael Zanetti
-
PreviewRatingInput: Use displayText instead of text to enable/disable the Send button (LP: #1595910)
Approved by: Andrea Cimitan, Christian Dywan, Unity8 CI Bot
- 2754. By Michael Zanetti
-
Add a D-Bus interface to control some debug facilities on the fly
Approved by: Gerry Boland, Unity8 CI Bot
- 2755. By Michael Zanetti
-
some launcher workarounds for the snapping
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2756. By dobey
-
Remove the payments widget and dependency on libpay as no longer needed.
Approved by: Andrea Cimitan, Unity8 CI Bot
- 2757. By Lukáš Tinkl
-
Fix touch window controls being unreachable when the overlay is being displayed (LP: #1648167)
Approved by: Josh Arenson, Unity8 CI Bot
- 2758. By Albert Astals Cid
-
Give focus to one of the buttons of the dialog
This one you can use Tab/Alt+Tab to navigate through them.
Unfortunately there's still the problem that if there's some other elements that take focus (like indicators), focus will also travel through them, but this is an start.
Approved by: Daniel d'Andrada, Unity8 CI Bot
- 2759. By Albert Astals Cid
-
tst_WindowResiz
eArea: Use default values for mouseFlick speed and iterations (LP: #1651580) Approved by: Daniel d'Andrada, Unity8 CI Bot
- 2760. By Albert Astals Cid
-
Require Qt 5.6 & misc fixes
Require Qt 5.6:
We align with what we're really testing
We can use Q_ENUM/Q_FLAG instead of Q_ENUMS/Q_FLAGS (Qt 5.5)CursorImageInfo.cpp
Join two QString::arg into oneSessionsModel.cpp
UsersModel.cpp
Remove useless Q_Ddashconnection.cpp
ColorTheme.cpp
UserMetrics.cpp
horizontaljournaltest. cpp
listviewwithpageheadersectione xternalmodeltes t.cpp
organicgridtest.cpp
verticaljournaltest.cpp
QObjects should have the Q_OBJECT macroindicatorsmodel.h
fakeindicatorsmodel.h
There's no Roles enum, removeappdrawerproxym
odel.cpp
MirSurfaceItem.cpp
Add & to the foreach variableappdrawerproxym
odel.cpp
Make the string comparison fastereasingcurve.h
Remove QEasingCurve::Type declaration, it's already in Qtunitysortfilter
proxymodelqml. h
fake_scopesoverview.h
Make some parent functions accessible to remove clang warningsPageList.cpp
unitymenumodel.cpp
qinputdeviceinfo_mock. cpp
Better way to iterate the containerGreeter.cpp
Cheaper env var checkingmediaplayer.cpp
mediaplayer.h
Rename timerEvent, clang was not happy since QObject has another oneApplicationInfo.h
Mark as overrideMockAppDrawerMo
del.cpp
launchermodeltest.cpp
screens.cpp
Fix warningfake_previewwid
getmodel. h
Forward declare struct the same way it is defined laterfake_scopes.cpp
Safer connecthorizontaljourn
altest. cpp
verticaljournaltest.cpp
testutil.cpp
Use at instead of [] in temporarylaunchermodelas
test.cpp
Remove unused member
Use toModelIndex() instead of value<QModelIndex>() Approved by: Michael Zanetti, Unity8 CI Bot
- 2761. By Lukáš Tinkl
-
Fixup paths for window state storage in snappy environment
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2762. By Josh Arenson
-
Allow the scopes list to automatically scroll when a scope is being dragged past the bounds of the screen. (LP: #1575319)
Approved by: Andrea Cimitan, Unity8 CI Bot
- 2763. By Daniel van Vugt
-
Deprecate usage of Mir's input resampling, instead opting for:
Shell: Raw native input events
Apps: Qt's built-in touch compression input resampling algorithm,
and other toolkits are expected to provide their own.This fixes LP: #1497105 nicely, allowing apps to receive the full-speed
input stream (if they ask their toolkit to give it to them).As an added bonus this also eliminates the 0-16.9ms (average 8.4ms) of
input lag that apps under Unity8 would experience. We do still have the
problem of output lag making everything still look laggy but I am
working to eliminate that soon in Mir 0.26.0. (LP: #1497105, #1591328)Approved by: Gerry Boland, Unity8 CI Bot
- 2764. By Lukáš Tinkl
-
Add Unity.Platform mock for our tests (LP: #1655336)
Approved by: Michał Sawicz
- 2765. By Michał Sawicz
-
Nuke leftover Platform in IndicatorsManager
Approved by: Nick Dedekind
- 2766. By CI Train Bot Account
-
Releasing 8.15+17.
04.20170110. 4-0ubuntu1 - 2767. By CI Train Bot Account
-
Resync trunk.
- 2768. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2769. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2770. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2771. By Lukáš Tinkl
-
Fix keymap not being applied on the shell itself (LP: #1626435)
Approved by: Gerry Boland, Unity8 CI Bot
- 2772. By Albert Astals Cid
-
Limit tab-focus travelling on dialogs with a fence
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2773. By Lukáš Tinkl
-
Shell dialog improvements (kbd focus, mouse eater)
Approved by: Michael Zanetti, Unity8 CI Bot
- 2774. By Albert Astals Cid
-
Restore focus to where it was when our ShellDialogs get unloaded
UITK Dialogs want to have this feature but it seems to be broken, so i'm fixing it here first (since we use dialogs in a kind of special way)
I'll try to fix UITK nextApproved by: Andrea Cimitan, Unity8 CI Bot
- 2775. By Michael Terry
-
Simplify the lightdm mock to make future greeter improvements easier to test.
I simplified the mock liblightdm to avoid separate files for the Private classes. That can all go into the main files. The separation isn't worth wading through the files to find what you want.
And I dropped the mock LightDM plugin entirely. (opting instead for a tiny "mock()" API call on the real plugin that returns an object that can be used to manipulate our mock liblightdm, if we're in testing mode)
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2776. By Josh Arenson
-
Add a test for the session chooser icon in the greeter's sessions list
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2777. By Michael Terry
-
Add support for guest sessions in unity8-greeter.
Adds support for the "hasGuestAccount" and "selectGuest" LightDM hints and does so largely by having the users model report a "*guest" user, rather than adding special support in qml.
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2778. By Michael Terry
-
Add support for LightDM hints for manual logins and hiding normal users.
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2779. By Michael Terry
-
Use a model for PAM prompts, supporting more possible interactions.
- This lets us show more than one message and more than one prompt from PAM.
- We now also show error text when a user enters a wrong password. This matches unity7-greeter behavior.
- Similarly, when a fingerprint login is attempted, but we are demanding a real login (e.g. the user hasn't logged in before), we now show a message to explain that a bit.
- Simplify the Greeter/View interactions a bit. We no longer need to signal quite as much events, since the view reflects the prompts model directly.
- Fix keyboard focus highlight handling among prompts.
- Update and expand the tests.
Approved by: Albert Astals Cid
- 2780. By Albert Astals Cid
-
Update current session after changing the user
This matches unity7 greeter behaviour, i.e. if you change the session and then change the user, the session that shows up is the last session that new user logged in and not the new session you selected in the previous user
Approved by: Josh Arenson, Unity8 CI Bot
- 2781. By Albert Astals Cid
-
Add keyboard navigation for Indicators
Esc closes
Left/Right selects prev/next indicatorApproved by: Michael Zanetti, Unity8 CI Bot
- 2782. By Nick Dedekind
-
Added Alt+F10 shortcut to open app menus. (LP: #1656896)
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2783. By Daniel d'Andrada
-
Simplify DecoratedWindow
Reduce the number of nested MouseAreas
Approved by: Nick Dedekind, Unity8 CI Bot
- 2784. By Nick Dedekind
-
Fixed menu layout width calculations. (LP: #1657050)
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2785. By Michael Zanetti
-
hint the launcher to indicate a successful size change to the user (LP: #1646457)
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2786. By Lukáš Tinkl
-
Start searching directly as you type, w/o having to first focus/click the search field.
Approved by: Michael Zanetti, Unity8 CI Bot
- 2787. By Michael Zanetti
-
Improvements for the appdrawer
Allow cancelling of the reveal gesture
move the app store uri to a gsetting (LP: #1648173)Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2788. By Michael Zanetti
-
Adjust home key to still focus the dash instead of messing with the drawer
Approved by: Lukáš Tinkl
- 2789. By Albert Astals Cid
-
a window -> the current window
Approved by: Lukáš Tinkl
- 2790. By Lukáš Tinkl
-
Add a test for the real implementation of WindowStateStorage
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2791. By Albert Astals Cid
-
There's no spreadDelegate_ anymore
Goes from ~9 to ~3 minutes
Approved by: Michael Zanetti, Unity8 CI Bot
- 2792. By Michael Terry
-
Fix grouping of autopkg output and allow optionally passing arguments to installed test scripts.
Approved by: Albert Astals Cid, Unity8 CI Bot
- 2793. By Lukáš Tinkl
-
Use a four finger gesture to open the drawer, much like in u7
Approved by: Michael Zanetti, Unity8 CI Bot
- 2794. By Michael Zanetti
-
allow 4 finger simulation with mousetouchadaptor
Approved by: Lukáš Tinkl, Unity8 CI Bot
- 2795. By Nick Dedekind
-
Skip Panel::
test_drag_ indicator_ item_down_ shows_menu Approved by: Lukáš Tinkl, Michał Sawicz, Unity8 CI Bot
- 2796. By Daniel d'Andrada
-
Remove unnecessary warning message
It's being printed on every initialization for quite a while now and it's not prompting us
to perform any action. Thus this can't be really a warning if it's always there.Approved by: Michael Zanetti, Unity8 CI Bot
- 2797. By CI Train Bot Account
-
Releasing 8.15+17.
04.20170124- 0ubuntu1 - 2798. By Launchpad Translations on behalf of unity-team
-
Launchpad automatic translations update.
- 2799. By Michael Terry
-
Drop IntegratedLightDM and always use system liblightdm instead
Unmerged revisions
- 2799. By Michael Terry
-
Drop IntegratedLightDM and always use system liblightdm instead
FAILED: Continuous integration, rev:2019 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/2092/ /unity8- jenkins. ubuntu. com/job/ build/2740/ console /unity8- jenkins. ubuntu. com/job/ build-0- fetch/2768 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= vivid+overlay/ 2641 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial+ overlay/ 2641 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= yakkety/ 2641 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 2633 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 2633/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 2633 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 2633/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= yakkety/ 2633/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 2633 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 2633/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 2633 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 2633/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= yakkety/ 2633/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 2633 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 2633/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 2633 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 2633/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= yakkety/ 2633/console
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/2092/ rebuild
https:/