Merge lp://qastaging/~mterry/update-manager/continue-on-error into lp://qastaging/update-manager
Proposed by
Michael Terry
| Status: | Merged |
|---|---|
| Merged at revision: | 2566 |
| Proposed branch: | lp://qastaging/~mterry/update-manager/continue-on-error |
| Merge into: | lp://qastaging/update-manager |
| Diff against target: |
417 lines (+150/-45) 10 files modified
UpdateManager/Dialogs.py (+21/-10) UpdateManager/InstallProgress.py (+4/-1) UpdateManager/UpdateManager.py (+15/-9) UpdateManager/UpdateProgress.py (+6/-2) UpdateManager/UpdatesAvailable.py (+4/-2) UpdateManager/backend/InstallBackendAptdaemon.py (+13/-11) UpdateManager/backend/InstallBackendSynaptic.py (+2/-1) UpdateManager/backend/__init__.py (+3/-1) tests/test_stop_update.py (+11/-8) tests/test_update_error.py (+71/-0) |
| To merge this branch: | bzr merge lp://qastaging/~mterry/update-manager/continue-on-error |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Vogt (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
When an update error occurs, currently Software Updater just stops completely with the error. This branch implements the part of the spec [1] that covers errors during update. Specifically:
* Show a dialog with the error, and Settings, Try Again, and OK buttons.
* If OK is pressed with updates, show a sub-header that notes there were some errors.
* If OK is pressed with no updates, show a slightly different message than normal (one less confident that system is up to date).
Tests added too for most of the code paths.
[1] Spec not quite updated yet, but see mpt's comments: https:/
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks good, +1. Nice tests as well.