Merge lp://qastaging/~mterry/webbrowser-app/snap-appid into lp://qastaging/webbrowser-app/staging
Proposed by
Michael Terry
| Status: | Merged |
|---|---|
| Approved by: | Olivier Tilloy |
| Approved revision: | 1577 |
| Merged at revision: | 1605 |
| Proposed branch: | lp://qastaging/~mterry/webbrowser-app/snap-appid |
| Merge into: | lp://qastaging/webbrowser-app/staging |
| Diff against target: |
11 lines (+1/-1) 1 file modified
snap/webbrowser-app.launcher (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mterry/webbrowser-app/snap-appid |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Olivier Tilloy | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2017-02-09.
Commit message
Properly set the APP_ID variable for the snappy world.
Description of the change
Properly set the APP_ID variable for the snappy world.
In snappy, it's SNAPNAME_
This doesn't matter a lot, I don't think. But one thing it was breaking was opening URLs from url-dispatcher. The APP_ID is used to expose a path on DBus for url-dispatcher to call, and it won't be found unless the above scheme is used.
To post a comment you must log in.
Revision history for this message
| Michael Terry (mterry) wrote | # |
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
Revision history for this message
| Michael Terry (mterry) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'll note that url-dispatcher doesn't work out of the box even with this fix. There's currently no way for webbrowser-app to register its url protocols with unity8 yet. That's coming, but I was doing some manual testing ahead of that.