Merge lp://qastaging/~mthaddon/charm-haproxy/errorfile-bytemode into lp://qastaging/charm-haproxy
Proposed by
Tom Haddon
| Status: | Merged |
|---|---|
| Approved by: | Barry Price |
| Approved revision: | 162 |
| Merged at revision: | 163 |
| Proposed branch: | lp://qastaging/~mthaddon/charm-haproxy/errorfile-bytemode |
| Merge into: | lp://qastaging/charm-haproxy |
| Diff against target: |
12 lines (+1/-1) 1 file modified
hooks/hooks.py (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mthaddon/charm-haproxy/errorfile-bytemode |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Barry Price | Approve | ||
| Canonical IS Reviewers | Pending | ||
|
Review via email:
|
|||
Commit message
base64.b64decode returns bytes rather than a string, so open the errorfile we'll write to in byte mode
Description of the change
base64.b64decode returns bytes rather than a string, so open the errorfile we'll write to in byte mode
To post a comment you must log in.
Revision history for this message
| 🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote | # |
Revision history for this message
| 🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.