Compiz

Merge lp://qastaging/~muktupavels/compiz/add-gwd-application-v3 into lp://qastaging/compiz/0.9.12

  1. add-gwd-application-v3
  2. Merge into 0.9.12
Proposed by Alberts Muktupāvels
Status: Work in progress
Proposed branch: lp://qastaging/~muktupavels/compiz/add-gwd-application-v3
Merge into: lp://qastaging/compiz/0.9.12
Prerequisite: lp://qastaging/~muktupavels/compiz/gwd-remove-2d
Diff against target: 838 lines (+360/-107)
14 files modified
gtk/window-decorator/CMakeLists.txt (+1/-0)
gtk/window-decorator/blurprops.c (+1/-1)
gtk/window-decorator/decorator.c (+1/-1)
gtk/window-decorator/events.c (+4/-4)
gtk/window-decorator/frames.c (+1/-1)
gtk/window-decorator/gtk-window-decorator.c (+5/-6)
gtk/window-decorator/gtk-window-decorator.h (+2/-0)
gtk/window-decorator/gwd-application.c (+149/-0)
gtk/window-decorator/gwd-application.h (+40/-0)
gtk/window-decorator/gwd-theme-cairo.c (+73/-1)
gtk/window-decorator/gwd-theme-metacity.c (+62/-14)
gtk/window-decorator/gwd-theme.c (+20/-74)
gtk/window-decorator/gwd-theme.h (+0/-4)
gtk/window-decorator/wnck.c (+1/-1)
To merge this branch: bzr merge lp://qastaging/~muktupavels/compiz/add-gwd-application-v3
Reviewer Review Type Date Requested Status
Sam Spilsbury Needs Fixing
Review via email: mp+295921@code.qastaging.launchpad.net

Commit message

gtk-window-decorator: add GWDApplication.

Description of the change

gtk-window-decorator: add GWDApplication.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

See diff comments (use after free).

I don't quite understand the purpose of this abstraction either. Could you add a little more detail in the description of the change or the commit message explaining the need to create a GWDApplication? It seems to me like we just moved parts of GWDTheme over to it.

review: Needs Fixing
Reply
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> See diff comments (use after free).
>
> I don't quite understand the purpose of this abstraction either. Could you add
> a little more detail in the description of the change or the commit message
> explaining the need to create a GWDApplication? It seems to me like we just
> moved parts of GWDTheme over to it.

Will fix use after free and also update description when I will be back to my main pc. GWDSettings moved to GWDApplication is only small part.

It looks like there is no reason to create style window for each frame style - so I will create only one style window and GWDApplication will be good place to store/keep it.

Also GWDTheme probably can be moved to it like other global variables, for example, frame_table... I simply want keep merge proposals more or less simple so it is easier to review.

Reply

Unmerged revisions

4051. By Alberts Muktupāvels

Remove uneeded include.

4050. By Alberts Muktupāvels

Remove get_settings from GWDTheme.

4049. By Alberts Muktupāvels

Add GWDApplication.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches