Compiz

Merge lp://qastaging/~muktupavels/compiz/ccsm-key-error into lp://qastaging/compiz/0.9.13

  1. ccsm-key-error
  2. Merge into 0.9.13
Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 4161
Merged at revision: 4168
Proposed branch: lp://qastaging/~muktupavels/compiz/ccsm-key-error
Merge into: lp://qastaging/compiz/0.9.13
Diff against target: 25 lines (+7/-4)
1 file modified
compizconfig/ccsm/ccm/Pages.py (+7/-4)
To merge this branch: bzr merge lp://qastaging/~muktupavels/compiz/ccsm-key-error
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Dmitry Shachnev Approve
Review via email: mp+349666@code.qastaging.launchpad.net

Commit message

ccsm: fix KeyError warnings.

Description of the change

Fix KeyError warnings in advanced search.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Tip for next time: if you add parentheses then you don't need to escape newlines:

if (self.CurrentPlugin is not None
    and self.CurrentPlugin.Name in self.Results
    and self.CurrentGroup in self.Results[self.CurrentPlugin.Name]):
    ...

Like you wrote is also fine though.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches