Merge lp://qastaging/~muktupavels/compiz/gtest into lp://qastaging/compiz/0.9.13

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 4177
Merged at revision: 4171
Proposed branch: lp://qastaging/~muktupavels/compiz/gtest
Merge into: lp://qastaging/compiz/0.9.13
Prerequisite: lp://qastaging/~muktupavels/compiz/gcc-8.1
Diff against target: 1186 lines (+189/-176)
26 files modified
cmake/CompizCommon.cmake (+7/-1)
cmake/GoogleTest.cmake (+51/-54)
compizconfig/gsettings/tests/test_gsettings_tests.cpp (+7/-7)
compizconfig/gsettings/tests/test_gsettings_wrapper.cpp (+1/-1)
compizconfig/integration/gnome/gsettings/tests/compizconfig_test_ccs_gnome_gsettings_integrated_setting.cpp (+5/-6)
compizconfig/integration/mate/gsettings/tests/compizconfig_test_ccs_mate_gsettings_integrated_setting.cpp (+5/-6)
compizconfig/libcompizconfig/tests/compizconfig_test_ccs_object.cpp (+17/-17)
compizconfig/libcompizconfig/tests/compizconfig_test_ccs_setting.cpp (+3/-5)
compizconfig/tests/compizconfig_backend_concept_test.h (+4/-5)
debian/control (+1/-0)
plugins/composite/src/pixmapbinding/tests/test-composite-pixmapbinding.cpp (+11/-11)
plugins/decor/tests/acceptance/xorg-gtest/compiz_decor_acceptance_tests.cpp (+12/-11)
plugins/expo/src/wall_offset/tests/test-expo-wall-offset.cpp (+3/-4)
plugins/place/src/constrain-to-workarea/tests/constrain-to-workarea/src/test-place-constrain-to-workarea.cpp (+14/-13)
plugins/place/src/screen-size-change/tests/screen-size-change/src/test-place-screen-size-change.cpp (+1/-1)
src/option/tests/option.cpp (+2/-2)
src/privatescreen/tests/test-privatescreen.cpp (+10/-4)
src/region/tests/test-region.cpp (+2/-2)
src/timer/tests/set-values/src/test-timer-set-values.cpp (+4/-4)
src/window/geometry-saver/tests/window-geometry-saver/src/test-window-geometry-saver.cpp (+14/-7)
src/window/geometry/tests/window-geometry/src/test-window-geometry.cpp (+4/-3)
tests/system/xorg-gtest/tests/compiz_xorg_gtest_ewmh.cpp (+1/-1)
tests/system/xorg-gtest/tests/compiz_xorg_gtest_icccm.cpp (+1/-1)
tests/system/xorg-gtest/tests/compiz_xorg_gtest_test_window_stacking.cpp (+8/-8)
tests/xorg-gtest/plugins/testhelper/src/testhelper.cpp (+1/-1)
tests/xorg-gtest/src/compiz_xorg_gtest_main.cpp (+0/-1)
To merge this branch: bzr merge lp://qastaging/~muktupavels/compiz/gtest
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Dmitry Shachnev Pending
Review via email: mp+349803@code.qastaging.launchpad.net

Commit message

Make tests build again with Google Test 1.8.0 and GCC 8.1.

Description of the change

Make tests build again with Google Test 1.8.0 and GCC 8.1.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

As for the unsigned checks on EXPECT's in unity we ended up on ignoring them, since they were too many to fix, but fine here.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches