Merge lp://qastaging/~muktupavels/compiz/gwd-improve-metacity into lp://qastaging/compiz/0.9.12

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 4075
Merged at revision: 4058
Proposed branch: lp://qastaging/~muktupavels/compiz/gwd-improve-metacity
Merge into: lp://qastaging/compiz/0.9.12
Prerequisite: lp://qastaging/~muktupavels/compiz/gwd-theme-style-window
Diff against target: 233 lines (+59/-47)
1 file modified
gtk/window-decorator/gwd-theme-metacity.c (+59/-47)
To merge this branch: bzr merge lp://qastaging/~muktupavels/compiz/gwd-improve-metacity
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+296868@code.qastaging.launchpad.net

Commit message

gtk-window-decorator: improve Metacity theme.

- Don't re-create MetaStyleInfo every time, we need to do this only when we get style-updated signal. Also with Metacity theme style info is almost unused - so creating / destroying was unneeded work. Style info only is used to create titlebar font and in meta_theme_draw_frame.

- Update invisible grab area size calculation. MetaFrameBorders might not be same between maximized and non-maximized windows.

Description of the change

- Don't re-create MetaStyleInfo every time, we need to do this only when we get style-updated signal. Also with Metacity theme style info is almost unused - so creating / destroying was unneeded work. Style info only is used to create titlebar font and in meta_theme_draw_frame.

- Update invisible grab area size calculation. MetaFrameBorders might not be same between maximized and non-maximized windows.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

LGTM otherwise

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

"Is there any reason why these blocks which are both contingent on the same if statement aren't in the same block anymore? (e.g. flags & META_FRAME_ALLOWS_VERTICAL_RESIZE)"

Invisible border size between normal and maximized window can be different. So we need first get borders for normal window and then for maximized window.

Probably `if (flags & META_FRAME_ALLOWS_*_RESIZE)` can be removed. If resize is not allowed then invisible border will be 0.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Good for me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches