Merge lp://qastaging/~muktupavels/compiz/gwd-improve-settings-storage into lp://qastaging/compiz/0.9.12

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 4053
Merged at revision: 4048
Proposed branch: lp://qastaging/~muktupavels/compiz/gwd-improve-settings-storage
Merge into: lp://qastaging/compiz/0.9.12
Prerequisite: lp://qastaging/~muktupavels/compiz/gwd-meta-theme-get-title-scale-removed
Diff against target: 619 lines (+147/-275)
8 files modified
gtk/window-decorator/gwd-settings-storage.c (+145/-60)
gtk/window-decorator/gwd-settings-storage.h (+2/-0)
gtk/window-decorator/tests/CMakeLists.txt (+0/-48)
gtk/window-decorator/tests/compiz_gwd_tests.h.in (+0/-31)
gtk/window-decorator/tests/org.gnome.desktop.wm.preferences.gschema.xml (+0/-72)
gtk/window-decorator/tests/org.gnome.metacity.gschema.xml (+0/-10)
gtk/window-decorator/tests/org.mate.marco.gschema.xml (+0/-53)
gtk/window-decorator/tests/test_gwd_settings.cpp (+0/-1)
To merge this branch: bzr merge lp://qastaging/~muktupavels/compiz/gwd-improve-settings-storage
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+296207@code.qastaging.launchpad.net

Commit message

gtk-window-decorator: improve GWDSettingsStorage

- Remove unused GSettings schemas from tests.
- If gtk-window-decorator is used with GNOME session other than GNOME-Flashback then use theme from org.gnome.desktop.wm.preferences schema.
- Don't create GSettings objects for schemas that is not needed in current desktop.

Description of the change

- Remove unused GSettings schemas from tests.
- If gtk-window-decorator is used with GNOME session other than GNOME-Flashback then use theme from org.gnome.desktop.wm.preferences schema.
- Don't create GSettings objects for schemas that is not needed in current desktop.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) :
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Have some minor nits and questions

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Good one

review: Approve
Revision history for this message
Alberts Muktupāvels (muktupavels) :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches