Merge lp://qastaging/~muktupavels/compiz/gwd-theme-style-window into lp://qastaging/compiz/0.9.12

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 4076
Merged at revision: 4057
Proposed branch: lp://qastaging/~muktupavels/compiz/gwd-theme-style-window
Merge into: lp://qastaging/compiz/0.9.12
Prerequisite: lp://qastaging/~muktupavels/compiz/gwd-titlebar-font
Diff against target: 1218 lines (+380/-333)
10 files modified
gtk/window-decorator/decorator.c (+23/-26)
gtk/window-decorator/frames.c (+2/-252)
gtk/window-decorator/gtk-window-decorator.c (+0/-1)
gtk/window-decorator/gtk-window-decorator.h (+0/-7)
gtk/window-decorator/gwd-theme-cairo.c (+218/-5)
gtk/window-decorator/gwd-theme-metacity.c (+29/-18)
gtk/window-decorator/gwd-theme.c (+73/-1)
gtk/window-decorator/gwd-theme.h (+6/-1)
gtk/window-decorator/switcher.c (+19/-22)
gtk/window-decorator/wnck.c (+10/-0)
To merge this branch: bzr merge lp://qastaging/~muktupavels/compiz/gwd-theme-style-window
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+296867@code.qastaging.launchpad.net

Commit message

gtk-window-decorator: use only one style window.

- Use only one style window - there is no reason to keep multiple windows. More windows just meant that on style-updated signal we called decorations_changed multiple times for no reason - just extra work.

- Switcher label was added to style window, but my tests shows that it is not needed...

- On style-updated signal _title_color was updated multiple times, but it is used only by Cairo theme.

Description of the change

- Use only one style window - there is no reason to keep multiple windows. More windows just meant that on style-updated signal we called decorations_changed multiple times for no reason - just extra work.

- Switcher label was added to style window, but my tests shows that it is not needed...

- On style-updated signal _title_color was updated multiple times, but it is used only by Cairo theme.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Fine. Good a try to an offscreenwindow once you've time.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches