Merge lp://qastaging/~muktupavels/sni-qt/fix-register-item-call into lp://qastaging/sni-qt
Proposed by
Alberts Muktupāvels
| Status: | Merged |
|---|---|
| Approved by: | Łukasz Zemczak |
| Approved revision: | 99 |
| Merged at revision: | 100 |
| Proposed branch: | lp://qastaging/~muktupavels/sni-qt/fix-register-item-call |
| Merge into: | lp://qastaging/sni-qt |
| Diff against target: |
75 lines (+18/-2) 3 files modified
src/statusnotifieritem.cpp (+15/-1) src/statusnotifieritem.h (+2/-0) src/statusnotifieritemfactory.cpp (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~muktupavels/sni-qt/fix-register-item-call |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Dmitry Shachnev | Approve | ||
| Łukasz Zemczak | Approve | ||
| Renato Araujo Oliveira Filho | Pending | ||
|
Review via email:
|
|||
Commit message
Fix RegisterStatusN
Description of the change
Fix RegisterStatusN
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me, although I didn't test it thoroughly as I would like to test it. I approved the very same change in appmenu-qt5 though, but would be nice if someone else would also give it a spin before top-approving.