Merge ~muktupavels/unity:compizconfig into unity:master

Proposed by Alberts Muktupāvels
Status: Merged
Approved by: Dmitry Shachnev
Approved revision: 13c3da2178cd909be1429ca3c33ef861e028387a
Merged at revision: 825afea3cf21c111c38cb391617b3550738a7e7c
Proposed branch: ~muktupavels/unity:compizconfig
Merge into: unity:master
Diff against target: 247 lines (+134/-1)
15 files modified
data/CMakeLists.txt (+1/-0)
data/compiz/CMakeLists.txt (+26/-0)
data/compiz/unity-lowgfx.ini (+53/-0)
data/compiz/unity.conf (+11/-0)
data/compiz/unity.ini (+2/-0)
data/compiz/upgrades/com.canonical.unity.unity-lowgfx.01.upgrade (+12/-0)
data/compiz/upgrades/com.canonical.unity.unity.01.upgrade (+5/-0)
data/compiz/upgrades/com.canonical.unity.unity.02.upgrade (+8/-0)
data/compiz/upgrades/com.canonical.unity.unity.03.upgrade (+2/-0)
data/compiz/upgrades/com.canonical.unity.unity.04.upgrade (+2/-0)
data/compiz/upgrades/com.canonical.unity.unity.05.upgrade (+3/-0)
data/compiz/upgrades/com.canonical.unity.unity.06.upgrade (+2/-0)
data/compiz/upgrades/com.canonical.unity.unity.07.upgrade (+2/-0)
debian/control (+3/-1)
debian/unity.install (+2/-0)
Reviewer Review Type Date Requested Status
Khurshid Alam (community) Approve
Marco Trevisan (Treviño) Pending
Dmitry Shachnev Pending
Review via email: mp+362759@code.qastaging.launchpad.net

Commit message

Install compiz configuration files.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I think we no longer need 00_remove_obsolete_plugins_in_unity_session_v3.py.

We do not support upgrades from versions before Ubuntu 18.04, and 18.04 users already have this migration applied.

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> I think we no longer need 00_remove_obsolete_plugins_in_unity_session_v3.py.
>
> We do not support upgrades from versions before Ubuntu 18.04, and 18.04 users
> already have this migration applied.

Removed commit that added this file.

Revision history for this message
Dmitry Shachnev (mitya57) :
Revision history for this message
Khurshid Alam (khurshid-alam) wrote :
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> Unity not compiling against this compiz?
>
> https://code.launchpad.net/~khurshid-alam/+archive/ubuntu/experimental-
> ppa/+build/16364462/+files/buildlog_ubuntu-disco-amd64.unity_7.5.0+19.04.20190
> 103-0ubuntu1+201902071650~ubuntu19.04.1_BUILDING.txt.gz

There was few problems and this change depends on changes in compiz.

> Also nux requires a fix first against gcc > 8.1
> (https://bugs.launchpad.net/ubuntu/+source/nux/+bug/1815094)

This seems to be unrelated, that can be fixed and uploaded separately, no?

> And it's better if we open a bug for this.

Why? This was Trevinho reply when I asked about moving files:
"it's mostly an historic reason, since unity was depending on compiz-gnome, but yes... All should have been moved to unity side since long time"

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

> There was few problems and this change depends on changes in compiz.

I was compiling compiz from your branch though but there was a release in disco today, that's why it didn't work...trying again..

>This seems to be unrelated, that can be fixed and uploaded separately, no?

Yes, I will someone from unity team, I just wanted to compile unity against nux.

> Why?

Just to keep track where and when it happened, but I am ok if none objects.

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

In the ppa I can't build unity

The following packages have unmet dependencies:
 builddeps:unity : Depends: libcompizconfig0-dev (>= 1:0.9.13.1+19.04.20190207.3-0ubuntu1) but it is not going to be installed

Can it be removed from debian/control ? May be add a break for libcompizconfig0 ?

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

https://bileto.ubuntu.com/#/ticket/3639
https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3639/+packages

Wait when this ppa will be ready and use it for testing... Unity build will start (I guess) when compiz will be published in the repository.

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

Working here.

review: Approve
Revision history for this message
Khurshid Alam (khurshid-alam) :
review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches