Merge lp://qastaging/~mvo/python-apt/recv-key-lp1016643 into lp://qastaging/~mvo/python-apt/debian-sid-mirrored
Proposed by
Michael Vogt
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~mvo/python-apt/recv-key-lp1016643 |
| Merge into: | lp://qastaging/~mvo/python-apt/debian-sid-mirrored |
| Diff against target: |
7611 lines (+1528/-1069) 65 files modified
apt/auth.py (+108/-31) apt/progress/base.py (+1/-1) aptsources/sourceslist.py (+1/-1) data/templates/Debian.info.in (+30/-0) debian/changelog (+60/-0) debian/control (+3/-1) doc/source/library/apt.progress.base.rst (+1/-1) doc/source/library/apt_pkg.rst (+4/-4) po/ar.po (+17/-12) po/be.po (+50/-35) po/bg.po (+18/-12) po/bn.po (+18/-12) po/ca.po (+18/-12) po/cs.po (+18/-12) po/csb.po (+17/-12) po/da.po (+19/-12) po/de.po (+17/-12) po/el.po (+17/-12) po/en_AU.po (+18/-12) po/en_CA.po (+18/-12) po/eo.po (+17/-12) po/es.po (+139/-132) po/fi.po (+17/-12) po/fr.po (+17/-12) po/gl.po (+18/-12) po/he.po (+18/-12) po/hr.po (+18/-12) po/hu.po (+17/-12) po/id.po (+17/-12) po/it.po (+18/-12) po/ja.po (+107/-115) po/ka.po (+18/-12) po/ko.po (+18/-12) po/ku.po (+18/-12) po/lt.po (+18/-12) po/lv.po (+17/-12) po/mk.po (+18/-12) po/nb.po (+18/-12) po/ne.po (+18/-12) po/nl.po (+17/-12) po/no.po (+18/-12) po/oc.po (+18/-12) po/pl.po (+126/-137) po/pt.po (+18/-12) po/pt_BR.po (+17/-12) po/python-apt.pot (+17/-12) po/ro.po (+18/-12) po/ru.po (+17/-14) po/sk.po (+17/-12) po/sl.po (+17/-12) po/sq.po (+17/-12) po/sr.po (+17/-30) po/sv.po (+18/-12) po/th.po (+18/-12) po/tl.po (+17/-12) po/tr.po (+18/-12) po/uk.po (+18/-12) po/vi.po (+18/-12) po/zh_CN.po (+18/-12) po/zh_HK.po (+18/-12) po/zh_TW.po (+18/-12) python/cache.cc (+1/-1) tests/fakeroot-apt-key (+1/-1) tests/test_aptsources.py (+14/-0) tests/test_auth.py (+18/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mvo/python-apt/recv-key-lp1016643 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Vogt | Needs Resubmitting | ||
| Julian Andres Klode (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Verify key after downloading from the keyserver
To post a comment you must log in.
Unmerged revisions
- 643. By Michael Vogt
-
add changelog entry
- 642. By Michael Vogt
-
apt/auth.py: fix trailing whitespace
- 641. By Michael Vogt
-
apt/auth.py: proper cleanup
- 640. By Michael Vogt
-
check fingerprint after downloading a key and before adding it
- 639. By Michael Vogt
-
support only downloading long keyids (160bit) in add_key_
from_keyserver( ) - 638. By Michael Vogt
-
merged lp:~jamesodhunt/python-apt/fix-for-PkgCacheGetIsMultiArch
- 637. By Michael Vogt
- 636. By Michał Kułach
-
po/pl.po: Polish (Michał Kułach) (closes: #684308)
- 635. By Julian Andres Klode
-
Release 0.8.7
- 634. By Julian Andres Klode
-
apt/auth.py: Forward stderr from apt-key to our stderr if non-empty
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Seems to be almost fine. Needs a changelog entry and the trailing whitespace should be removed. The switch from SystemError to AptKeyError should be fine as long as there are no existing users in the Ubuntu archive; otherwise add breaks for those or make SystemError a base class of AptKeyError.
Launchpad really has some problems though, it appears to not have updated lp:python-apt to anything newer than 0.8.5. We should probably report a bug somewhere.