snap-confine

Merge lp://qastaging/~mvo/snap-confine/environment-file into lp://qastaging/~snappy-dev/snap-confine/trunk

  1. environment-file
  2. Merge into trunk
Proposed by Michael Vogt
Status: Needs review
Proposed branch: lp://qastaging/~mvo/snap-confine/environment-file
Merge into: lp://qastaging/~snappy-dev/snap-confine/trunk
Diff against target: 203 lines (+147/-0)
6 files modified
debian/usr.bin.ubuntu-core-launcher (+3/-0)
src/environment.c (+85/-0)
src/environment.h (+23/-0)
src/main.c (+4/-0)
tests/common.sh (+4/-0)
tests/test_environment (+28/-0)
To merge this branch: bzr merge lp://qastaging/~mvo/snap-confine/environment-file
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Needs Fixing
Review via email: mp+295237@code.qastaging.launchpad.net

Description of the change

This implements passing environment variables that got defined via the snapd daemon. This is useful to avoid having to manually write wrappers in snapcraft. Instead the environment is part of meta/snap.yaml and will get generated automatically on install by snapd.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Note that this does not yet work for LD_LIBRARY_PATH, the strong suspicion is that the apparmor profile in debian/usr.bin.ubuntu-core-launcher prevents that via the apparmor environment scrubbing functionality.

Reply
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Just one bug below

review: Needs Fixing
Reply
lp://qastaging/~mvo/snap-confine/environment-file updated
139. By Michael Vogt

fix missing dereference (thanks @zyga)

Revision history for this message
Michael Vogt (mvo) wrote :

@zyga Thanks! Good catch on the missing deref.

Reply
Revision history for this message
Tyler Hicks (tyhicks) wrote :

> Note that this does not yet work for LD_LIBRARY_PATH, the strong suspicion is
> that the apparmor profile in debian/usr.bin.ubuntu-core-launcher prevents that
> via the apparmor environment scrubbing functionality.

I'm tracking this with https://launchpad.net/bugs/1584069

Reply
Revision history for this message
Leo Arias (elopio) :
Reply
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

mvo can you please retarget this to snap-confine, we're closing this repository

Reply

Unmerged revisions

139. By Michael Vogt

fix missing dereference (thanks @zyga)

138. By Michael Vogt

kill final \n

137. By Michael Vogt

fix confinment, improve debug

136. By Michael Vogt

add support for adding an environment from a special environment file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches