snap-confine

Merge lp://qastaging/~mvo/snap-confine/snappy-on-ubuntu into lp://qastaging/~snappy-dev/snap-confine/trunk

  1. snappy-on-ubuntu
  2. Merge into trunk
Proposed by Michael Vogt
Status: Merged
Merged at revision: 83
Proposed branch: lp://qastaging/~mvo/snap-confine/snappy-on-ubuntu
Merge into: lp://qastaging/~snappy-dev/snap-confine/trunk
Diff against target: 117 lines (+71/-5)
1 file modified
src/main.c (+71/-5)
To merge this branch: bzr merge lp://qastaging/~mvo/snap-confine/snappy-on-ubuntu
Reviewer Review Type Date Requested Status
Snappy Developers Pending
Review via email: mp+278938@code.qastaging.launchpad.net

Description of the change

This branch implements the ability to run snappy apps on a classic ubuntu system by mounting parts of the ubuntu snappy core OS snap for the running app.

To post a comment you must log in.
lp://qastaging/~mvo/snap-confine/snappy-on-ubuntu updated
87. By Michael Vogt

simplify is_running_on_classic_ubuntu() (thanks pitti)

88. By Michael Vogt

use MS_SLAVE mount for "/" (thanks pitti!)

89. By Michael Vogt

src/main.c: use debug() instead of fprintf() for debug prints

Revision history for this message
Martin Pitt (pitti) wrote :

Looks much nicer now, thanks! Some further nitpicks inline.

Revision history for this message
Martin Pitt (pitti) :
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for this excellent review!

lp://qastaging/~mvo/snap-confine/snappy-on-ubuntu updated
90. By Michael Vogt

address review points from pitti, many thanks!

Revision history for this message
Tyler Hicks (tyhicks) wrote :

is_mountpoint() is added in this MP but there are no callers.

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks Tyler! I removed is_mountpoint() again.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches