Merge lp://qastaging/~mvo/snapcraft/add-snap-meta into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Michael Vogt
| Status: | Merged |
|---|---|
| Approved by: | Michael Terry |
| Approved revision: | 83 |
| Merged at revision: | 83 |
| Proposed branch: | lp://qastaging/~mvo/snapcraft/add-snap-meta |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
29 lines (+6/-0) 3 files modified
examples/gopaste/snapcraft.yaml (+2/-0) examples/libpipeline/snapcraft.yaml (+2/-0) examples/webcam-webui-snap/snapcraft.yaml (+2/-0) |
| To merge this branch: | bzr merge lp://qastaging/~mvo/snapcraft/add-snap-meta |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Holbach (community) | testing | Approve | |
| Michael Terry (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add location of the meta directory for the examples.
Description of the change
Tiny branch based on the feedback from dholbach that our examples do not work if you try "snapcraft assemble". I wonder if we should actually try the "meta" directory automatically if snap/meta is missing? Happy to create a branch for this too if needed, but AIUI there is still some open questiosn about the auto-generation of package.yaml
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM. I originally left them off because I didn't want to clutter the yaml when doing an actual demo. But that's not a concern anymore. :)
I'm leery of assuming that a "meta" directory sitting there is for our benefit. But maybe that's a harmless assumption.
In any case, this branch is fine as is. Thanks!