Merge lp://qastaging/~mvo/snapcraft/demo-pep8-pyflakes into lp://qastaging/~xubuntu-dev/snapcraft/demo
Proposed by
Michael Vogt
| Status: | Rejected |
|---|---|
| Rejected by: | Michael Terry |
| Proposed branch: | lp://qastaging/~mvo/snapcraft/demo-pep8-pyflakes |
| Merge into: | lp://qastaging/~xubuntu-dev/snapcraft/demo |
| Diff against target: |
1305 lines (+600/-494) 11 files modified
bin/snapcraft (+194/-169) plugins/autotools-project.py (+27/-21) plugins/go1.4-project.py (+4/-3) plugins/go1.4.py (+12/-7) plugins/make-project.py (+17/-11) plugins/snapcraft.py (+84/-74) plugins/tgz-content.py (+3/-1) run-checks.sh (+17/-0) snapcraft/__init__.py (+65/-56) snapcraft/common.py (+16/-12) snapcraft/plugin.py (+161/-140) |
| To merge this branch: | bzr merge lp://qastaging/~mvo/snapcraft/demo-pep8-pyflakes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Terry | Disapprove | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-06-30.
Commit message
pep8/pyflakes and reindent.
Description of the change
Sorry for the churn in this branch.
It fixes pep8/pyflakes issues and adds a "run-checks.py" script that enforces pep8/pyflakes. It also uses spaces instead of tabs as this is what pep8 recommends. I hope that is ok with you (ironically the reverse recommendation that go makes).
Its mostly mechanical so no human needs to go over the diff, I just didn't want to commit it directly in case there is concern about the changes :)
To post a comment you must log in.
Unmerged revisions
- 48. By Michael Vogt
-
pep8/pyflakes
- 47. By Michael Vogt
-
run reindent.py
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I have churned trunk so much since you proposed this (and I didn't notice, sorry!) that it no longer applies. But I separately did the pyflakes/pep8 bits myself, wasting energy that had already been spent on this branch. Whoops.