Snapcraft

Merge lp://qastaging/~mvo/snapcraft/fix-ftbfs into lp://qastaging/~snappy-dev/snapcraft/core

  1. fix-ftbfs
  2. Merge into core
Proposed by Michael Vogt
Status: Merged
Approved by: Michael Terry
Approved revision: 86
Merged at revision: 89
Proposed branch: lp://qastaging/~mvo/snapcraft/fix-ftbfs
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 19 lines (+2/-0)
1 file modified
debian/control (+2/-0)
To merge this branch: bzr merge lp://qastaging/~mvo/snapcraft/fix-ftbfs
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
Review via email: mp+264955@code.qastaging.launchpad.net

Commit message

add python3-apt to build-depends

Description of the change

Tiny branch that adds python3-apt to the build-depends to fix the recent
FTBFS in the testsuite.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Yup, whoops :(

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

Wait, don't you want it on the Depends: line for snapcraft too?

review: Needs Information
lp://qastaging/~mvo/snapcraft/fix-ftbfs updated
86. By Michael Vogt

debian/control: add python-apt to the dependencies too

Revision history for this message
Michael Vogt (mvo) wrote :

@Mike: Yeah, we probably want that too. I added it now, good catch! I was thinking about lazy loading it so that snapcraft could run on non-apt platforms, but a) we can always do that later b) iirc we agreed that ubuntu is the host.

Revision history for this message
Michael Terry (mterry) wrote :

Nice :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches