Merge lp://qastaging/~mvo/snapcraft/go-download-only into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Michael Vogt
| Status: | Merged |
|---|---|
| Approved by: | Sergio Schvezov |
| Approved revision: | 201 |
| Merged at revision: | 206 |
| Proposed branch: | lp://qastaging/~mvo/snapcraft/go-download-only |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
14 lines (+3/-1) 1 file modified
snapcraft/plugins/go_project.py (+3/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mvo/snapcraft/go-download-only |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sergio Schvezov | Approve | ||
|
Review via email:
|
|||
Commit message
The go plugin should only download in the pull phase
Description of the change
This fixes a autopkgtest failure for the examples (godd specifically).
The fix is to only download and not build the go dependencies in the pull phase. The actual building is done in the build phase. This broke because the build needs the gudev pkgconfig file, but that file is not yet available, it will be downloaded during pull as a "stage" package though.
It actually does not fix the autopkgtest failure until the pkg-config support branch lands.
To post a comment you must log in.
Revision history for this message
| Sergio Schvezov (sergiusens) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
