Snapcraft

Merge lp://qastaging/~mvo/snapcraft/more-python-apt into lp://qastaging/~ted/snapcraft/arbitrary-repos

  1. more-python-apt
  2. Merge into arbitrary-repos
Proposed by Michael Vogt
Status: Work in progress
Proposed branch: lp://qastaging/~mvo/snapcraft/more-python-apt
Merge into: lp://qastaging/~ted/snapcraft/arbitrary-repos
Diff against target: 99 lines (+27/-41)
2 files modified
examples/ros/snapcraft.yaml (+11/-0)
snapcraft/repo.py (+16/-41)
To merge this branch: bzr merge lp://qastaging/~mvo/snapcraft/more-python-apt
Reviewer Review Type Date Requested Status
Michael Vogt (community) Needs Fixing
Sergio Schvezov (community) Needs Fixing
Ted Gould Pending
Review via email: mp+270831@code.qastaging.launchpad.net

Description of the change

Fix "can not find python-argparse" error by using the python-apt resolver to find the dependencies of the packages.

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

it seems that manifest.txt is not required anymore, mind cleaning it from setup.py and also getting rid of self.manifest_dep_names or not removing it and doing a elif pkg.candidate.name in self.manifest_dep_names unless whatever is in manifest.txt is already covered by your condition.

review: Needs Fixing
Reply
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Thanks for the simplification btw

Reply
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

One more comment, not sure if it is good, but it was originally like that.

Also, can you use single quotes for strings?

Reply
lp://qastaging/~mvo/snapcraft/more-python-apt updated
160. By Michael Vogt

address sergios review points

Revision history for this message
Michael Vogt (mvo) wrote :

One open question here is what to do with manifest.txt

review: Needs Fixing
Reply

Unmerged revisions

160. By Michael Vogt

address sergios review points

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: