Merge lp://qastaging/~mvo/snapcraft/split_init into lp://qastaging/~mterry/snapcraft/x-local-plugin
Proposed by
Michael Vogt
| Status: | Merged |
|---|---|
| Merge reported by: | Michael Terry |
| Merged at revision: | not available |
| Proposed branch: | lp://qastaging/~mvo/snapcraft/split_init |
| Merge into: | lp://qastaging/~mterry/snapcraft/x-local-plugin |
| Diff against target: |
245 lines (+124/-56) 3 files modified
snapcraft/plugin.py (+74/-53) snapcraft/tests/mock_plugin.py (+21/-0) snapcraft/tests/test_plugin.py (+29/-3) |
| To merge this branch: | bzr merge lp://qastaging/~mvo/snapcraft/split_init |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Terry | Pending | ||
|
Review via email:
|
|||
Description of the change
This is my attempt to add unitt tests for the lp:~mterry/snapcraft/x-local-plugin branch.
Some of it might be a bit controversial, please just let me know if you dislike it:
- renamed Plugin the Plugin to PluginHandler, probably not the best name, I tried to make it clearer that Plugin is not BasePlugin. Plugin also embedds a BasePlugin subclass in .code so I thought it "handles" plugins. Happy about ideas for a better name (or if you think its fine). Other ideas might be PluginWrapper, PluginManager, PluginWrangler
- I split __init__() into smaller functions but its does not yet buy us much :/ (except that I find it easier to read this way)
To post a comment you must log in.
Revision history for this message
| Michael Terry (mterry) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice, thanks mvo! Merged into mine.