Merge lp://qastaging/~mvo/snappy/15.04-ppp-config into lp://qastaging/~snappy-dev/snappy/15.04-deprecated

Proposed by Michael Vogt
Status: Merged
Approved by: Michael Vogt
Approved revision: 473
Merged at revision: 475
Proposed branch: lp://qastaging/~mvo/snappy/15.04-ppp-config
Merge into: lp://qastaging/~snappy-dev/snappy/15.04-deprecated
Prerequisite: lp://qastaging/~mvo/snappy/15.04-network-config
Diff against target: 320 lines (+158/-30)
2 files modified
coreconfig/config.go (+61/-27)
coreconfig/config_test.go (+97/-3)
To merge this branch: bzr merge lp://qastaging/~mvo/snappy/15.04-ppp-config
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Sergio Schvezov Needs Fixing
Review via email: mp+270624@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-09-10.

Commit message

Add configuration for ppp via ubuntu-core-config

Description of the change

This branch adds configuration for ppp via ubuntu-core-config

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Looks good, you just have the same error as in the modprobe one:
var [name] [type] = "string" (type is cruft)

review: Needs Fixing
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

one nitpick

472. By Michael Vogt

address review comments

473. By Michael Vogt

merged partent

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, fixed!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches