Snappy

Merge lp://qastaging/~mvo/snappy/snappy-modify-name-value-file into lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github

  1. snappy-modify-name-value-file
  2. Merge into snappy-moved-to-github
Proposed by Michael Vogt
Status: Work in progress
Proposed branch: lp://qastaging/~mvo/snappy/snappy-modify-name-value-file
Merge into: lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github
Prerequisite: lp://qastaging/~mvo/snappy/snappy-atomic-write-once
Diff against target: 398 lines (+171/-123)
4 files modified
helpers/helpers.go (+69/-0)
helpers/helpers_test.go (+73/-0)
partition/bootloader_uboot.go (+19/-109)
partition/bootloader_uboot_test.go (+10/-14)
To merge this branch: bzr merge lp://qastaging/~mvo/snappy/snappy-modify-name-value-file
Reviewer Review Type Date Requested Status
Snappy Developers Pending
Review via email: mp+264130@code.qastaging.launchpad.net

Description of the change

This branch implements the suggestions from Sergio to move ModifyNameValueFile into helpers and use a map for the key/value changes.

To post a comment you must log in.

Unmerged revisions

575. By Michael Vogt

helpers/helpers.go: refactor ModifyNameValueFile for (hopefully) easier readability

574. By Michael Vogt

add TestModifyNameValueFileModifyExistingNoUselessWrites

573. By Michael Vogt

move ModifyNameValueFile() into helpers

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches