Snappy

Merge lp://qastaging/~mvo/snappy/snappy-panic-less into lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github

snappy-panic-less
Merge into snappy-moved-to-github

Proposed by Michael Vogt on 2015-10-22

Status:	Needs review
Proposed branch:	lp://qastaging/~mvo/snappy/snappy-panic-less
Merge into:	lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github
Diff against target:	38 lines (+9/-4) 2 files modified priv/priv.go (+0/-3) priv/priv_test.go (+9/-1)
To merge this branch:	bzr merge lp://qastaging/~mvo/snappy/snappy-panic-less
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
John Lenton (community)		2015-10-22	Approve on 2015-10-22
Review via email: mp+275280@code.qastaging.launchpad.net

Description of the change

Tiny branch that fixes a panic when doing:
"""
priv := New(lockfile)
priv.Lock()
priv.Unlock()
priv.Lock()
"""

Kudos to John Lenton for discovering this isssue.

Revision history for this message

John Lenton (chipaca) wrote on 2015-10-22:

Hah.

I didn't do this myself because I didn't understand why it was being nil'ed, so left it alone.

That it can be removed entirely is good news :)

review: Approve

Revision history for this message

Michael Vogt (mvo) wrote on 2015-10-22:

On Thu, Oct 22, 2015 at 09:38:50AM -0000, John Lenton wrote:
> Review: Approve
>
> Hah.
>
> I didn't do this myself because I didn't understand why it was being nil'ed, so left it alone.
>
> That it can be removed entirely is good news :)

I don't know either (I didn't write the code), but looking at the code
I don't think its required (famous last words) so lets fix it and see
what breaks.

Thanks,
Michael