Merge lp://qastaging/~mvo/snappy/snappy-review-tools-reenable into lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github

Yes please. Top approve if/when the tools are ready.

FAILED: Continuous integration, rev:573
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mvo/snappy/snappy-review-tools-reenable/+merge/264301/+edit-commit-message

http://10.55.60.183:8080/job/snappy-rolling-ci/26/
Executed test runs:

Click here to trigger a rebuild:
http://10.55.60.183:8080/job/snappy-rolling-ci/26/rebuild

We have an integration test that builds a snap: http://bazaar.launchpad.net/~snappy-dev/snappy/snappy/view/head:/_integration-tests/tests/build_test.go#L49
The build is done in the snappy machine, and it is not expecting the warning we get when click-review is not installed. So, the test needs to be updated to match a more relaxed rexexp. And we need a new card to test more builds including the review, but that should probably wait until comfy is properly defined.

START: /tmp/snappy-tests-job/24707/src/launchpad.net/snappy/_integration-tests/tests/build_test.go:49: buildSuite.TestBuildBasicSnapOnSnappy
START: <autogenerated>:7: buildSuite.SetUpTest
****** Running buildSuite.TestBuildBasicSnapOnSnappy
[...]

snappy build _integration-tests/data/snaps/basic
Warning: could not review package (click-review not available)
Generated 'basic_1.0_all.snap' snap
/tmp/snappy-tests-job/24707/src/launchpad.net/snappy/_integration-tests/tests/build_test.go:55:
    ...open /tmp/snappy-tests-job/24707/src/launchpad.net/snappy/_integration-tests/tests/build_test.go: no such file or directory
... obtained string = "" +
... "Warning: could not review package (click-review not available)\n" +
... "Generated 'basic_1.0_all.snap' snap\n"
... expected string = "Generated 'basic_1.0_all.snap' snap\n"

This branch was somehow forgotten. We should resurrect it :) What needs to happen for the test? Can we just install click-reviewers-tools from the tools PPA?

After merging with trunk, something like this makes the test pass.

http://paste.ubuntu.com/12705348/

We can't install the reviewer tools because we are doing the build on snappy itself. Well, we could install them, but not with apt-get.
Now that your classic dimension snappy is coming, we can move the build to that environment, and test more things. For now, this will do.

Thanks Leo! I updated the branch and applied your patch. Hopefully its ready now.

:D