Merge lp://qastaging/~mvo/snappy/snappy-snapfs-needs-reboot into lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github

Proposed by Michael Vogt
Status: Needs review
Proposed branch: lp://qastaging/~mvo/snappy/snappy-snapfs-needs-reboot
Merge into: lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github
Prerequisite: lp://qastaging/~mvo/snappy/snappy-snapfs-os-kernel
Diff against target: 211 lines (+81/-21)
6 files modified
cmd/snappy/cmd_list.go (+1/-1)
partition/bootloader.go (+6/-7)
partition/partition.go (+6/-0)
snappy/common_test.go (+1/-0)
snappy/snapp.go (+23/-0)
snappy/snapp_snapfs_test.go (+44/-13)
To merge this branch: bzr merge lp://qastaging/~mvo/snappy/snappy-snapfs-needs-reboot
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+274976@code.qastaging.launchpad.net

Commit message

Implement NeedsReboot() for kernel/os snaps.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

getting there!

+1'ing it, but there are a couple of nits.

review: Approve
782. By Michael Vogt

fix reboot-required test

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your excellent review, I simplified the code and update it on github.

Unmerged revisions

782. By Michael Vogt

fix reboot-required test

781. By Michael Vogt

show a reboot required message (not complete yet)

780. By Michael Vogt

go fmt

779. By Michael Vogt

partition/partition.go: IsNextBootOther() is always false on all-snap systems

778. By Michael Vogt

add missing tests for reboot-required reporting

777. By Michael Vogt

partition/bootloader.go: its ok to not have an "other" partition

776. By Michael Vogt

snappy/snapp.go: detect if kernel/os needs reboot

775. By Michael Vogt

partition/bootloader.go: do not crash if "/" is not system-{a,b}

774. By Michael Vogt

fix tests

773. By Michael Vogt

mered lp:snappy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches